[parser] Only log messages using the pending error handling

src/pending-compilation-error-handler.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/pending-compilation-error-handler.h"
 
 #include "src/ast/ast-value-factory.h"
 #include "src/debug/debug.h"
 #include "src/handles.h"
 #include "src/isolate.h"
 #include "src/messages.h"
 
 namespace v8 {
 namespace internal {
 
+Handle<String> PendingCompilationErrorHandler::ArgumentString(
+    Isolate* isolate) {
+  if (arg_ != NULL) return arg_->string();
+  if (char_arg_ != NULL) {
+    return isolate->factory()
+        ->NewStringFromUtf8(CStrVector(char_arg_))
+        .ToHandleChecked();
+  }
+  if (!handle_arg_.is_null()) return handle_arg_;
+  return isolate->factory()->undefined_string();
+}
+
+Handle<String> PendingCompilationErrorHandler::FormatMessage(Isolate* isolate) {

[vogelheim, 2016/11/15 08:43:42]

Who calls this? Is it only for testing?

[Toon Verwaest, 2016/11/15 10:12:24]

Yeah just testing. It seems small enough that it doesn't matter it's here...

+  return MessageTemplate::FormatMessage(isolate, message_,
+                                        ArgumentString(isolate));
+}
+
 void PendingCompilationErrorHandler::ThrowPendingError(Isolate* isolate,
                                                        Handle<Script> script) {
   if (!has_pending_error_) return;
   MessageLocation location(script, start_position_, end_position_);
   Factory* factory = isolate->factory();
-  Handle<String> argument;
-  if (arg_ != NULL) {
-    argument = arg_->string();
-  } else if (char_arg_ != NULL) {
-    argument =
-        factory->NewStringFromUtf8(CStrVector(char_arg_)).ToHandleChecked();
-  } else if (!handle_arg_.is_null()) {
-    argument = handle_arg_;
-  }
+  Handle<String> argument = ArgumentString(isolate);
   isolate->debug()->OnCompileError(script);
 
   Handle<Object> error;
   switch (error_type_) {
     case kReferenceError:
       error = factory->NewReferenceError(message_, argument);
       break;
     case kSyntaxError:
       error = factory->NewSyntaxError(message_, argument);
       break;
@@ skipping 19 matching lines @@
                         handle(Smi::FromInt(location.end_pos()), isolate),
                         SLOPPY).Check();
 
   Handle<Name> key_script = factory->error_script_symbol();
   JSObject::SetProperty(jserror, key_script, script, SLOPPY).Check();
 
   isolate->Throw(*error, &location);
 }
 }  // namespace internal
 }  // namespace v8