Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2502613002: Revert of [turbofan] Fix deoptimization of boolean bit constants. (Closed)

Created:
4 years, 1 month ago by Jarin
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Fix deoptimization of boolean bit constants. (patchset #1 id:1 of https://codereview.chromium.org/2495243002/ ) Reason for revert: Seems to break GC stress. Original issue's description: > [turbofan] Fix deoptimization of boolean bit constants. > > BUG=chromium:664490 TBR=bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:664490 Committed: https://crrev.com/1c9528c4c44e0a1bce2fae9d4e2363420746744d Cr-Commit-Position: refs/heads/master@{#40961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -27 lines) Patch
M src/compiler/code-generator.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D test/mjsunit/compiler/regress-664490.js View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jarin
Created Revert of [turbofan] Fix deoptimization of boolean bit constants.
4 years, 1 month ago (2016-11-14 12:10:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502613002/1
4 years, 1 month ago (2016-11-14 12:10:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 12:10:34 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:32:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c9528c4c44e0a1bce2fae9d4e2363420746744d
Cr-Commit-Position: refs/heads/master@{#40961}

Powered by Google App Engine
This is Rietveld 408576698