Fix asan build. Duh, don't return a stack address...

Fix asan build.  Duh, don't return a stack address...

BUG=

[robertphillips, 2013-09-27 13:23:58]

lgtm

[commit-bot: I haz the power, 2013-09-27 13:39:59]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/mtklein@google.com/25026004/1

[commit-bot: I haz the power, 2013-09-27 13:40:01]

Failed to apply patch for bench/MathBench.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file bench/MathBench.cpp
  Hunk #1 FAILED at 514.
  1 out of 1 hunk FAILED -- saving rejects to file bench/MathBench.cpp.rej

Patch:       bench/MathBench.cpp
Index: bench/MathBench.cpp
diff --git a/bench/MathBench.cpp b/bench/MathBench.cpp
index
260159f3f0ebf58b513f1f16fb53e406130e9f1f..abe04e13d705cd97bb90bfe80a176fc34b0bbe79
100644
--- a/bench/MathBench.cpp
+++ b/bench/MathBench.cpp
@@ -514,15 +514,16 @@ private:
 
 template <typename T>
 class DivModBench : public SkBenchmark {
-    const char* fName;
+    SkString fName;
 public:
-    explicit DivModBench(const char* name) : fName(name) {
+    explicit DivModBench(const char* name) {
+        fName.printf("divmod_%s", name);
         fIsRendering = false;
     }
 
 protected:
     virtual const char* onGetName() {
-        return SkStringPrintf("divmod_%s", fName).c_str();
+        return fName.c_str();
     }
 
     virtual void onDraw(SkCanvas*) {

[mtklein, 2013-09-27 13:41:19]

On 2013/09/27 13:40:01, I haz the power (commit-bot) wrote:
> Failed to apply patch for bench/MathBench.cpp:
> While running patch -p1 --forward --force --no-backup-if-mismatch;
>   patching file bench/MathBench.cpp
>   Hunk #1 FAILED at 514.
>   1 out of 1 hunk FAILED -- saving rejects to file bench/MathBench.cpp.rej
> 
> Patch:       bench/MathBench.cpp
> Index: bench/MathBench.cpp
> diff --git a/bench/MathBench.cpp b/bench/MathBench.cpp
> index
>
260159f3f0ebf58b513f1f16fb53e406130e9f1f..abe04e13d705cd97bb90bfe80a176fc34b0bbe79
> 100644
> --- a/bench/MathBench.cpp
> +++ b/bench/MathBench.cpp
> @@ -514,15 +514,16 @@ private:
>  
>  template <typename T>
>  class DivModBench : public SkBenchmark {
> -    const char* fName;
> +    SkString fName;
>  public:
> -    explicit DivModBench(const char* name) : fName(name) {
> +    explicit DivModBench(const char* name) {
> +        fName.printf("divmod_%s", name);
>          fIsRendering = false;
>      }
>  
>  protected:
>      virtual const char* onGetName() {
> -        return SkStringPrintf("divmod_%s", fName).c_str();
> +        return fName.c_str();
>      }
>  
>      virtual void onDraw(SkCanvas*) {

Ah, I thought my manual commit didn't work, but I guess it did.  Sorry for the
confusion CommitBot!