Issue 2502593003: Make a QuicDefaultPacketWriter method virtual, and check member variable directly. No behavior chan…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2502593003: Make a QuicDefaultPacketWriter method virtual, and check member variable directly. No behavior chan… (Closed)

Created:
4 years, 1 month ago by mpw

Modified:
4 years, 1 month ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make a QuicDefaultPacketWriter method virtual, and check member variable directly. No behavior change. Merge internal change: 138383388 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	net/tools/quic/quic_default_packet_writer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	net/tools/quic/quic_default_packet_writer.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download

Dependent Patchsets:

Issue 2506903002 Patch 1

Issue 2506903002 Patch 20001

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages