Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 250253002: Mojo: Add String, Float, and Double types to codec.js. (Closed)

Created:
6 years, 8 months ago by Matt Perry
Modified:
6 years, 7 months ago
Reviewers:
sky, abarth-chromium
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Add String type to codec.js. Also simplify the encoding/decoding code in the bindings generator. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266733

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : string array test #

Patch Set 4 : . #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -61 lines) Patch
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M content/test/data/web_ui_test_mojo_bindings.mojom View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/bindings/js/codec_unittests.js View 2 chunks +29 lines, -0 lines 0 comments Download
M mojo/public/js/bindings/codec.js View 1 2 3 6 chunks +28 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 1 2 2 chunks +15 lines, -57 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
Matt Perry
6 years, 8 months ago (2014-04-23 20:36:56 UTC) #1
abarth-chromium
lgtm
6 years, 8 months ago (2014-04-23 21:40:25 UTC) #2
Matt Perry
The CQ bit was checked by mpcomplete@chromium.org
6 years, 8 months ago (2014-04-23 21:52:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/250253002/20001
6 years, 8 months ago (2014-04-23 21:53:29 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 23:08:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-23 23:08:19 UTC) #6
Matt Perry
+sky for web_ui_mojo OWNERS
6 years, 8 months ago (2014-04-24 23:45:55 UTC) #7
sky
LGTM - but meta question about these, and should have asked Tom too. How come ...
6 years, 8 months ago (2014-04-25 14:34:14 UTC) #8
Matt Perry
The CQ bit was checked by mpcomplete@chromium.org
6 years, 8 months ago (2014-04-25 19:35:53 UTC) #9
Matt Perry
The CQ bit was checked by mpcomplete@chromium.org
6 years, 8 months ago (2014-04-25 20:45:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/250253002/80001
6 years, 8 months ago (2014-04-25 21:41:21 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 22:33:48 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg tryserver.chromium on mac_chromium_compile_dbg
6 years, 8 months ago (2014-04-25 22:33:49 UTC) #13
Matt Perry
The CQ bit was checked by mpcomplete@chromium.org
6 years, 8 months ago (2014-04-25 23:59:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/250253002/80001
6 years, 8 months ago (2014-04-26 00:01:42 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 00:52:13 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 8 months ago (2014-04-26 00:52:13 UTC) #17
Matt Perry
The CQ bit was checked by mpcomplete@chromium.org
6 years, 8 months ago (2014-04-26 00:53:04 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/250253002/80001
6 years, 8 months ago (2014-04-26 00:55:40 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 06:05:18 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg tryserver.chromium on mac_chromium_compile_dbg
6 years, 8 months ago (2014-04-26 06:05:19 UTC) #21
Matt Perry
The CQ bit was checked by mpcomplete@chromium.org
6 years, 7 months ago (2014-04-28 19:50:56 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/250253002/80001
6 years, 7 months ago (2014-04-28 19:51:31 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 19:54:50 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_clang_dbg
6 years, 7 months ago (2014-04-28 19:54:51 UTC) #25
Matt Perry
The CQ bit was checked by mpcomplete@chromium.org
6 years, 7 months ago (2014-04-28 20:04:56 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/250253002/100001
6 years, 7 months ago (2014-04-28 20:06:09 UTC) #27
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 01:52:54 UTC) #28
Message was sent while issue was closed. 
Change committed as 266733

Powered by Google App Engine
This is Rietveld 408576698