Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Side by Side Diff: services/video_capture/service_impl.cc

Issue 2502483003: [Mojo Video Capture] Cleanup naming of classes/files in services/video_capture (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/video_capture/video_capture_service.h" 5 #include "services/video_capture/service_impl.h"
6 6
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "media/capture/video/fake_video_capture_device_factory.h" 8 #include "media/capture/video/fake_video_capture_device_factory.h"
9 #include "media/capture/video/video_capture_buffer_pool.h" 9 #include "media/capture/video/video_capture_buffer_pool.h"
10 #include "media/capture/video/video_capture_buffer_tracker.h" 10 #include "media/capture/video/video_capture_buffer_tracker.h"
11 #include "media/capture/video/video_capture_jpeg_decoder.h" 11 #include "media/capture/video/video_capture_jpeg_decoder.h"
12 #include "services/service_manager/public/cpp/interface_registry.h" 12 #include "services/service_manager/public/cpp/interface_registry.h"
13 #include "services/video_capture/device_factory_media_to_mojo_adapter.h" 13 #include "services/video_capture/device_factory_media_to_mojo_adapter.h"
14 #include "services/video_capture/mock_device_factory.h" 14 #include "services/video_capture/mock_device_factory.h"
15 15
16 namespace { 16 namespace {
17 17
18 // TODO(chfremer): Replace with an actual decoder factory. 18 // TODO(chfremer): Replace with an actual decoder factory.
19 // https://crbug.com/584797 19 // https://crbug.com/584797
20 std::unique_ptr<media::VideoCaptureJpegDecoder> CreateJpegDecoder() { 20 std::unique_ptr<media::VideoCaptureJpegDecoder> CreateJpegDecoder() {
21 return nullptr; 21 return nullptr;
22 } 22 }
23 23
24 } // anonymous namespace 24 } // anonymous namespace
25 25
26 namespace video_capture { 26 namespace video_capture {
27 27
28 VideoCaptureService::VideoCaptureService() : mock_device_factory_(nullptr) {} 28 ServiceImpl::ServiceImpl()
29 : mock_device_factory_(nullptr) {}
29 30
30 VideoCaptureService::~VideoCaptureService() = default; 31 ServiceImpl::~ServiceImpl() = default;
31 32
32 bool VideoCaptureService::OnConnect( 33 bool ServiceImpl::OnConnect(
33 const service_manager::ServiceInfo& remote_info, 34 const service_manager::ServiceInfo& remote_info,
34 service_manager::InterfaceRegistry* registry) { 35 service_manager::InterfaceRegistry* registry) {
35 registry->AddInterface<mojom::VideoCaptureService>(this); 36 registry->AddInterface<mojom::Service>(this);
36 return true; 37 return true;
37 } 38 }
38 39
39 void VideoCaptureService::Create( 40 void ServiceImpl::Create(
40 const service_manager::Identity& remote_identity, 41 const service_manager::Identity& remote_identity,
41 mojom::VideoCaptureServiceRequest request) { 42 mojom::ServiceRequest request) {
42 service_bindings_.AddBinding(this, std::move(request)); 43 service_bindings_.AddBinding(this, std::move(request));
43 } 44 }
44 45
45 void VideoCaptureService::ConnectToDeviceFactory( 46 void ServiceImpl::ConnectToDeviceFactory(
46 mojom::VideoCaptureDeviceFactoryRequest request) { 47 mojom::DeviceFactoryRequest request) {
47 LazyInitializeDeviceFactory(); 48 LazyInitializeDeviceFactory();
48 factory_bindings_.AddBinding(device_factory_.get(), std::move(request)); 49 factory_bindings_.AddBinding(device_factory_.get(), std::move(request));
49 } 50 }
50 51
51 void VideoCaptureService::ConnectToFakeDeviceFactory( 52 void ServiceImpl::ConnectToFakeDeviceFactory(
52 mojom::VideoCaptureDeviceFactoryRequest request) { 53 mojom::DeviceFactoryRequest request) {
53 LazyInitializeFakeDeviceFactory(); 54 LazyInitializeFakeDeviceFactory();
54 fake_factory_bindings_.AddBinding(fake_device_factory_.get(), 55 fake_factory_bindings_.AddBinding(fake_device_factory_.get(),
55 std::move(request)); 56 std::move(request));
56 } 57 }
57 58
58 void VideoCaptureService::ConnectToMockDeviceFactory( 59 void ServiceImpl::ConnectToMockDeviceFactory(
59 mojom::VideoCaptureDeviceFactoryRequest request) { 60 mojom::DeviceFactoryRequest request) {
60 LazyInitializeMockDeviceFactory(); 61 LazyInitializeMockDeviceFactory();
61 mock_factory_bindings_.AddBinding(mock_device_factory_adapter_.get(), 62 mock_factory_bindings_.AddBinding(mock_device_factory_adapter_.get(),
62 std::move(request)); 63 std::move(request));
63 } 64 }
64 65
65 void VideoCaptureService::AddDeviceToMockFactory( 66 void ServiceImpl::AddDeviceToMockFactory(
66 mojom::MockVideoCaptureDevicePtr device, 67 mojom::MockMediaDevicePtr device,
67 const media::VideoCaptureDeviceDescriptor& descriptor, 68 const media::VideoCaptureDeviceDescriptor& descriptor,
68 const AddDeviceToMockFactoryCallback& callback) { 69 const AddDeviceToMockFactoryCallback& callback) {
69 LazyInitializeMockDeviceFactory(); 70 LazyInitializeMockDeviceFactory();
70 mock_device_factory_->AddMockDevice(std::move(device), std::move(descriptor)); 71 mock_device_factory_->AddMockDevice(std::move(device), std::move(descriptor));
71 callback.Run(); 72 callback.Run();
72 } 73 }
73 74
74 void VideoCaptureService::LazyInitializeDeviceFactory() { 75 void ServiceImpl::LazyInitializeDeviceFactory() {
75 if (device_factory_) 76 if (device_factory_)
76 return; 77 return;
77 78
78 // Create the platform-specific device factory. 79 // Create the platform-specific device factory.
79 // Task runner does not seem to actually be used. 80 // Task runner does not seem to actually be used.
80 std::unique_ptr<media::VideoCaptureDeviceFactory> media_device_factory = 81 std::unique_ptr<media::VideoCaptureDeviceFactory> media_device_factory =
81 media::VideoCaptureDeviceFactory::CreateFactory( 82 media::VideoCaptureDeviceFactory::CreateFactory(
82 base::MessageLoop::current()->task_runner()); 83 base::MessageLoop::current()->task_runner());
83 84
84 device_factory_ = base::MakeUnique<DeviceFactoryMediaToMojoAdapter>( 85 device_factory_ = base::MakeUnique<DeviceFactoryMediaToMojoAdapter>(
85 std::move(media_device_factory), base::Bind(CreateJpegDecoder)); 86 std::move(media_device_factory), base::Bind(CreateJpegDecoder));
86 } 87 }
87 88
88 void VideoCaptureService::LazyInitializeFakeDeviceFactory() { 89 void ServiceImpl::LazyInitializeFakeDeviceFactory() {
89 if (fake_device_factory_) 90 if (fake_device_factory_)
90 return; 91 return;
91 92
92 fake_device_factory_ = base::MakeUnique<DeviceFactoryMediaToMojoAdapter>( 93 fake_device_factory_ = base::MakeUnique<DeviceFactoryMediaToMojoAdapter>(
93 base::MakeUnique<media::FakeVideoCaptureDeviceFactory>(), 94 base::MakeUnique<media::FakeVideoCaptureDeviceFactory>(),
94 base::Bind(&CreateJpegDecoder)); 95 base::Bind(&CreateJpegDecoder));
95 } 96 }
96 97
97 void VideoCaptureService::LazyInitializeMockDeviceFactory() { 98 void ServiceImpl::LazyInitializeMockDeviceFactory() {
98 if (mock_device_factory_) 99 if (mock_device_factory_)
99 return; 100 return;
100 101
101 auto mock_device_factory = base::MakeUnique<MockDeviceFactory>(); 102 auto mock_device_factory = base::MakeUnique<MockDeviceFactory>();
102 // We keep a pointer to the MockDeviceFactory as a member so that we can 103 // We keep a pointer to the MockDeviceFactory as a member so that we can
103 // invoke its AddMockDevice(). Ownership of the MockDeviceFactory is moved 104 // invoke its AddMockDevice(). Ownership of the MockDeviceFactory is moved
104 // to the DeviceFactoryMediaToMojoAdapter. 105 // to the DeviceFactoryMediaToMojoAdapter.
105 mock_device_factory_ = mock_device_factory.get(); 106 mock_device_factory_ = mock_device_factory.get();
106 mock_device_factory_adapter_ = 107 mock_device_factory_adapter_ =
107 base::MakeUnique<DeviceFactoryMediaToMojoAdapter>( 108 base::MakeUnique<DeviceFactoryMediaToMojoAdapter>(
108 std::move(mock_device_factory), base::Bind(&CreateJpegDecoder)); 109 std::move(mock_device_factory), base::Bind(&CreateJpegDecoder));
109 } 110 }
110 111
111 } // namespace video_capture 112 } // namespace video_capture
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698