Fixed dragging a folder from bookmark manager to open all elements in new tabs

chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h"
 
 #import <QuartzCore/QuartzCore.h>
 
 #include <cmath>
 #include <limits>
@@ skipping 2088 matching lines @@
 
 // (URLDropTargetController protocol)
 - (void)dropURLs:(NSArray*)urls inView:(NSView*)view at:(NSPoint)point {
   DCHECK_EQ(view, tabStripView_.get());
 
   if ([urls count] < 1) {
     NOTREACHED();
     return;
   }
 
-  //TODO(viettrungluu): dropping multiple URLs.
-  if ([urls count] > 1)
-    NOTIMPLEMENTED();
+  NSInteger numTabsInserted = 0;
 
-  // Get the first URL and fix it up.
-  GURL url(GURL(url_formatter::FixupURL(
-      base::SysNSStringToUTF8([urls objectAtIndex:0]), std::string())));
+  for (id urlString in [urls reverseObjectEnumerator]) {
+    // Refactor this code.
+    // https://crbug.com/665261.
+    GURL url = url_formatter::FixupURL(base::SysNSStringToUTF8(urlString),
+                                       std::string());
 
-  // If the URL isn't valid, don't bother.
-  if (!url.is_valid())
-    return;
+    // If the URL isn't valid, don't bother.
+    if (!url.is_valid())
+      continue;
 
-  [self openURL:&url inView:view at:point];
+    [self openURL:&url inView:view at:point];
+
+    numTabsInserted++;
+  }
+
+  // Now select the last tab inserted.
+  tabStripModel_->ActivateTabAt(

[erikchen, 2016/11/18 18:26:21]

There are better ways of doing this.

You want to activate the last tab inserted. In order to do this, you need to
know meta-information [index] about the tabs that were inserted. This
information needs to propagate from openURL:... to here. The previous
implementation assumed that the last tab inserted would be the last tab in the
tab strip model. This implementation assumes that active_index() hasn't changed
since we started inserting tabs, and that tabs get inserted directly after
active_index(). 

I think you should add another parameter activate:(BOOL) to openURL:... and in
that method, call tabStripModel_->ActivateTabAt(index, true); if that parameter
is true. [I haven't looked into how the disposition might influence this, but
it's likely relevant as well].

[shahriar, 2016/11/21 02:52:38]

Thank you very much for the explanation. I make changes, as you said, but I
found I can rely on disposition, this way I don't have to manually call
activateTabAt(index, true). However I am not sure if I get the concept of
Foreground and Background tab properly. I am looking forward your kind comments
if I am making a mistake here. 

+      tabStripModel_->active_index() + numTabsInserted - 1, true);
 }
 
 // (URLDropTargetController protocol)
 - (void)dropText:(NSString*)text inView:(NSView*)view at:(NSPoint)point {
   DCHECK_EQ(view, tabStripView_.get());
 
   // If the input is plain text, classify the input and make the URL.
   AutocompleteMatch match;
   AutocompleteClassifierFactory::GetForProfile(browser_->profile())->Classify(
       base::SysNSStringToUTF16(text), false, false,
@@ skipping 206 matching lines @@
   for (int i = 0; i < tabStripModel_->count(); i++) {
     [self updateIconsForContents:tabStripModel_->GetWebContentsAt(i) atIndex:i];
   }
 }
 
 - (void)setVisualEffectsDisabledForFullscreen:(BOOL)fullscreen {
   [tabStripView_ setVisualEffectsDisabledForFullscreen:fullscreen];
 }
 
 @end