Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 250243002: Add nanosecond timer. (Closed)

Created:
6 years, 8 months ago by mtklein_C
Modified:
6 years, 8 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add nanosecond timer. I've been finding it hard to get enough resolution out of our existing timers when measuring really tiny pictures. BUG=skia:2378 Committed: http://code.google.com/p/skia/source/detail?r=14362

Patch Set 1 #

Patch Set 2 : update tools #

Patch Set 3 : mac fixes #

Patch Set 4 : try %ju #

Patch Set 5 : sigh, just use %u #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -23 lines) Patch
M include/core/SkTime.h View 1 chunk +3 lines, -1 line 0 comments Download
M include/core/SkTypes.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ports/SkTime_Unix.cpp View 1 2 2 chunks +31 lines, -9 lines 0 comments Download
M src/ports/SkTime_win.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M tools/bench_playback.cpp View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M tools/bench_record.cpp View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
mtklein
6 years, 8 months ago (2014-04-23 20:42:08 UTC) #1
bungeman-skia
Why aren't we using BenchTimer here?
6 years, 8 months ago (2014-04-23 20:54:21 UTC) #2
bsalomon
On 2014/04/23 20:42:08, mtklein wrote: lgtm if this lands in the AM when I'll be ...
6 years, 8 months ago (2014-04-23 21:16:59 UTC) #3
mtklein
On 2014/04/23 20:54:21, bungeman1 wrote: > Why aren't we using BenchTimer here? I can change ...
6 years, 8 months ago (2014-04-23 21:20:26 UTC) #4
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-04-24 13:52:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/250243002/10001
6 years, 8 months ago (2014-04-24 13:52:50 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 15:07:19 UTC) #7
commit-bot: I haz the power
Retried try job too often on Build-Mac10.8-Clang-x86-Release-Trybot for step(s) BuildEverything http://skia-tree-status.appspot.com/redirect/compile-buildbots/buildstatus?builder=Build-Mac10.8-Clang-x86-Release-Trybot&number=709
6 years, 8 months ago (2014-04-24 15:07:19 UTC) #8
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-04-24 15:55:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/250243002/30001
6 years, 8 months ago (2014-04-24 15:56:11 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 18:06:28 UTC) #11
commit-bot: I haz the power
Retried try job too often on Build-Ubuntu12-GCC-x86_64-Release-Trybot for step(s) BuildTools http://skia-tree-status.appspot.com/redirect/compile-buildbots/buildstatus?builder=Build-Ubuntu12-GCC-x86_64-Release-Trybot&number=2145
6 years, 8 months ago (2014-04-24 18:06:29 UTC) #12
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 8 months ago (2014-04-24 18:53:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/250243002/70001
6 years, 8 months ago (2014-04-24 18:53:54 UTC) #14
commit-bot: I haz the power
Change committed as 14362
6 years, 8 months ago (2014-04-24 20:04:23 UTC) #15
mtklein
6 years, 8 months ago (2014-04-24 20:16:52 UTC) #16
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/258703002/ by mtklein@google.com.

The reason for reverting is: breaks EVERYTHING.

Powered by Google App Engine
This is Rietveld 408576698