third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc - Issue 2502413004: WTF/std normalization: replace WTF::Vector::last with ::back

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc

Issue 2502413004: WTF/std normalization: replace WTF::Vector::last with ::back (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_layout_coordinator.cc ('k') | third_party/WebKit/Source/core/loader/TextResourceDecoderBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc b/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc

index fcb583502e3ffc1f29193c224d7efdc1753a2fef..029c2761fae0039f913a5bf687944d6a3d7eacf6 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc

@@ -13,7 +13,7 @@ namespace blink {

NGLayoutInlineItemsBuilder::~NGLayoutInlineItemsBuilder() {

DCHECK_EQ(0u, exits_.size());

- DCHECK_EQ(text_.length(), items_->isEmpty() ? 0 : items_->last().EndOffset());

+ DCHECK_EQ(text_.length(), items_->isEmpty() ? 0 : items_->back().EndOffset());

}

void NGLayoutInlineItemsBuilder::Append(const String& string,

@@ -100,8 +100,8 @@ void NGLayoutInlineItemsBuilder::ExitInline(LayoutObject* node) {

}

void NGLayoutInlineItemsBuilder::Exit(LayoutObject* node) {

- while (!exits_.isEmpty() && exits_.last().node == node) {

- Append(exits_.last().character, nullptr);

+ while (!exits_.isEmpty() && exits_.back().node == node) {

+ Append(exits_.back().character, nullptr);

exits_.pop_back();

}