third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h - Issue 2502413004: WTF/std normalization: replace WTF::Vector::last with ::back

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

Issue 2502413004: WTF/std normalization: replace WTF::Vector::last with ::back (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp ('k') | third_party/WebKit/Source/core/layout/ng/ng_layout_coordinator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

diff --git a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

index 5a0ce64065da155687cffbd2111d893c195edbda..c20ba8d6450bed7e2046820212cda8c2ce643d48 100644

--- a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

+++ b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

@@ -999,7 +999,7 @@ inline bool BreakingContext::handleText(WordMeasurements& wordMeasurements,

// new point.

lastSpaceWordSpacing = applyWordSpacing ? wordSpacing : 0;

wordSpacingForWordMeasurement =

- (applyWordSpacing && wordMeasurements.last().width) ? wordSpacing

+ (applyWordSpacing && wordMeasurements.back().width) ? wordSpacing

: 0;

stopIgnoringSpaces(lastSpace);

}

@@ -1168,7 +1168,7 @@ inline bool BreakingContext::handleText(WordMeasurements& wordMeasurements,

secondToLastCharacter);

wordMeasurements.grow(wordMeasurements.size() + 1);

- WordMeasurement& wordMeasurement = wordMeasurements.last();

+ WordMeasurement& wordMeasurement = wordMeasurements.back();

wordMeasurement.layoutText = layoutText;

// IMPORTANT: current.offset() is > layoutText.textLength() here!

@@ -1283,7 +1283,7 @@ inline WordMeasurement& BreakingContext::calculateWordWidth(

float wordTrailingSpaceWidth,

UChar c) {

wordMeasurements.grow(wordMeasurements.size() + 1);

- WordMeasurement& wordMeasurement = wordMeasurements.last();

+ WordMeasurement& wordMeasurement = wordMeasurements.back();

wordMeasurement.layoutText = layoutText;

wordMeasurement.endOffset = m_current.offset();

wordMeasurement.startOffset = lastSpace;