third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp - Issue 2502413004: WTF/std normalization: replace WTF::Vector::last with ::back

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

Issue 2502413004: WTF/std normalization: replace WTF::Vector::last with ::back (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp ('k') | third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

index 94658af9d97f33442bf3f185c3163eabe6245d1c..018674b69bf29463b61bd4211d593ef71e939a3d 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

@@ -251,7 +251,7 @@ void DocumentMarkerController::addMarker(Node* node,

RenderedDocumentMarker* newRenderedMarker =

RenderedDocumentMarker::create(newMarker);

updateMarkerRenderedRect(*node, *newRenderedMarker);

- if (list->isEmpty() || list->last()->endOffset() < newMarker.startOffset()) {

+ if (list->isEmpty() || list->back()->endOffset() < newMarker.startOffset()) {

list->append(newRenderedMarker);

} else {

if (newMarker.type() != DocumentMarker::TextMatch &&