third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp - Issue 2502413004: WTF/std normalization: replace WTF::Vector::last with ::back

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

Issue 2502413004: WTF/std normalization: replace WTF::Vector::last with ::back (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8HTMLConstructor.cpp ('k') | third_party/WebKit/Source/core/animation/CompositorAnimations.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

diff --git a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

index 8773ecfbe866f68577f3f386c04d9a698f91584b..79e2672e5124265ca8436dab4988c5ca7c830956 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

+++ b/third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

@@ -492,12 +492,12 @@ bool injectV8KeyIntoV8Value(v8::Isolate* isolate,

// Implicit properties don't need to be set. The caller is not required to

// be aware of this, so this is an expected no-op. The caller can verify

// that the value is correct via assertPrimaryKeyValidOrInjectable.

- if (isImplicitProperty(isolate, value, keyPathElements.last()))

+ if (isImplicitProperty(isolate, value, keyPathElements.back()))

return true;

// If it's not an implicit property of value, value must be an object.

v8::Local<v8::Object> object = value.As<v8::Object>();

- v8::Local<v8::String> property = v8String(isolate, keyPathElements.last());

+ v8::Local<v8::String> property = v8String(isolate, keyPathElements.back());

if (!v8CallBoolean(object->CreateDataProperty(context, property, key)))

return false;