Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2502413003: MD WebUI: Fix minor rendering problems in <cr-toolbar> (Closed)

Created:
4 years, 1 month ago by tsergeant
Modified:
4 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, dbeam+watch-elements_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-downloads_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: Fix minor rendering problems in <cr-toolbar> In crrev.com/589355, the <cr-toolbar> element moved from using paper-input to a native <input> element. This CL fixes two minor issues that came about as a result of this change: * Fix font rendering issues on macOS so that text is the right size and antialiased correctly * Ensure that right clicking shows the <input> context menu * Prevent label text from wrapping during animations BUG=589355, 666183, 666180 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/572f871f139ed9a514b69707a7e25345fff0de2b Cr-Commit-Position: refs/heads/master@{#433107}

Patch Set 1 #

Patch Set 2 : Nowrap label text #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M chrome/browser/resources/md_downloads/vulcanized.html View 1 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 3 chunks +6 lines, -2 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html View 1 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 26 (19 generated)
tsergeant
Please take a look -- just a small CSS change.
4 years, 1 month ago (2016-11-17 06:14:53 UTC) #5
Dan Beam
lgtm
4 years, 1 month ago (2016-11-17 19:23:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502413003/1
4 years, 1 month ago (2016-11-17 22:50:52 UTC) #12
tsergeant
I've uploaded a new patchset which fixes one more minor thing I found this morning: ...
4 years, 1 month ago (2016-11-18 00:00:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502413003/40001
4 years, 1 month ago (2016-11-18 02:20:42 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-18 04:37:46 UTC) #24
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 04:45:05 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/572f871f139ed9a514b69707a7e25345fff0de2b
Cr-Commit-Position: refs/heads/master@{#433107}

Powered by Google App Engine
This is Rietveld 408576698