|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by tsergeant Modified:
4 years, 1 month ago Reviewers:
Dan Beam CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, dbeam+watch-elements_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-downloads_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD WebUI: Fix minor rendering problems in <cr-toolbar>
In crrev.com/589355, the <cr-toolbar> element moved from using
paper-input to a native <input> element. This CL fixes two minor issues
that came about as a result of this change:
* Fix font rendering issues on macOS so that text is the right size and
antialiased correctly
* Ensure that right clicking shows the <input> context menu
* Prevent label text from wrapping during animations
BUG=589355, 666183, 666180
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/572f871f139ed9a514b69707a7e25345fff0de2b
Cr-Commit-Position: refs/heads/master@{#433107}
Patch Set 1 #Patch Set 2 : Nowrap label text #
Messages
Total messages: 26 (19 generated)
Description was changed from ========== MD WebUI: Fix minor problems with migration from paper-input In crrev.com/589355, the <cr-toolbar> element moved from using paper-input to a native <input> element. This CL fixes minor issues that came about as a result of this change: * Fix minor font rendering issues, particularly on macOS * Ensure that right clicking shows the <input> context menu BUG=589355,666183,666180 ========== to ========== MD WebUI: Fix minor problems with migration from paper-input In crrev.com/589355, the <cr-toolbar> element moved from using paper-input to a native <input> element. This CL fixes minor issues that came about as a result of this change: * Fix minor font rendering issues, particularly on macOS * Ensure that right clicking shows the <input> context menu BUG=589355,666183,666180 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== MD WebUI: Fix minor problems with migration from paper-input In crrev.com/589355, the <cr-toolbar> element moved from using paper-input to a native <input> element. This CL fixes minor issues that came about as a result of this change: * Fix minor font rendering issues, particularly on macOS * Ensure that right clicking shows the <input> context menu BUG=589355,666183,666180 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD WebUI: Fix minor rendering problems in <cr-toolbar> In crrev.com/589355, the <cr-toolbar> element moved from using paper-input to a native <input> element. This CL fixes two minor issues that came about as a result of this change: * Fix font rendering issues on macOS so that text is the right size and antialiased correctly * Ensure that right clicking shows the <input> context menu BUG=589355,666183,666180 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== MD WebUI: Fix minor rendering problems in <cr-toolbar> In crrev.com/589355, the <cr-toolbar> element moved from using paper-input to a native <input> element. This CL fixes two minor issues that came about as a result of this change: * Fix font rendering issues on macOS so that text is the right size and antialiased correctly * Ensure that right clicking shows the <input> context menu BUG=589355,666183,666180 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD WebUI: Fix minor rendering problems in <cr-toolbar> In crrev.com/589355, the <cr-toolbar> element moved from using paper-input to a native <input> element. This CL fixes two minor issues that came about as a result of this change: * Fix font rendering issues on macOS so that text is the right size and antialiased correctly * Ensure that right clicking shows the <input> context menu BUG=589355,666183,666180 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
tsergeant@chromium.org changed reviewers: + dbeam@chromium.org
Please take a look -- just a small CSS change.
The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm
The CQ bit was checked by tsergeant@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by tsergeant@chromium.org
Description was changed from ========== MD WebUI: Fix minor rendering problems in <cr-toolbar> In crrev.com/589355, the <cr-toolbar> element moved from using paper-input to a native <input> element. This CL fixes two minor issues that came about as a result of this change: * Fix font rendering issues on macOS so that text is the right size and antialiased correctly * Ensure that right clicking shows the <input> context menu BUG=589355,666183,666180 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD WebUI: Fix minor rendering problems in <cr-toolbar> In crrev.com/589355, the <cr-toolbar> element moved from using paper-input to a native <input> element. This CL fixes two minor issues that came about as a result of this change: * Fix font rendering issues on macOS so that text is the right size and antialiased correctly * Ensure that right clicking shows the <input> context menu * Prevent label text from wrapping during animations BUG=589355,666183,666180 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Patchset #2 (id:20001) has been deleted
I've uploaded a new patchset which fixes one more minor thing I found this morning: the label text wraps to a new line when animating from narrow to wide mode.
The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by tsergeant@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2502413003/#ps40001 (title: "Nowrap label text")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== MD WebUI: Fix minor rendering problems in <cr-toolbar> In crrev.com/589355, the <cr-toolbar> element moved from using paper-input to a native <input> element. This CL fixes two minor issues that came about as a result of this change: * Fix font rendering issues on macOS so that text is the right size and antialiased correctly * Ensure that right clicking shows the <input> context menu * Prevent label text from wrapping during animations BUG=589355,666183,666180 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD WebUI: Fix minor rendering problems in <cr-toolbar> In crrev.com/589355, the <cr-toolbar> element moved from using paper-input to a native <input> element. This CL fixes two minor issues that came about as a result of this change: * Fix font rendering issues on macOS so that text is the right size and antialiased correctly * Ensure that right clicking shows the <input> context menu * Prevent label text from wrapping during animations BUG=589355,666183,666180 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/572f871f139ed9a514b69707a7e25345fff0de2b Cr-Commit-Position: refs/heads/master@{#433107} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/572f871f139ed9a514b69707a7e25345fff0de2b Cr-Commit-Position: refs/heads/master@{#433107} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
