Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2502413002: Release PowerSaveBlock on PeerConnection stop instead of removal (Closed)

Created:
4 years, 1 month ago by Guido Urdaneta
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, haraken, feature-media-reviews_chromium.org, darin-cc_chromium.org, mac-reviews_chromium.org, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Release PowerSaveBlock on PeerConnection stop instead of removal. Removal occurs at GC time, which may result in an undeterminate amount of time with power saving blocked. Drive-by: fix a couple of lint issues. BUG=612294 Committed: https://crrev.com/542c74f6d402696e770d70a8716dbcf0ffe53094 Cr-Commit-Position: refs/heads/master@{#432920}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -10 lines) Patch
M content/browser/webrtc/webrtc_internals.h View 4 chunks +13 lines, -4 lines 1 comment Download
M content/browser/webrtc/webrtc_internals.cc View 5 chunks +23 lines, -3 lines 0 comments Download
M content/browser/webrtc/webrtc_internals_unittest.cc View 3 chunks +53 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Guido Urdaneta
Hi, PTAL
4 years, 1 month ago (2016-11-17 15:26:39 UTC) #7
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/2502413002/diff/60001/content/browser/webrtc/webrtc_internals.h File content/browser/webrtc/webrtc_internals.h (right): https://codereview.chromium.org/2502413002/diff/60001/content/browser/webrtc/webrtc_internals.h#newcode112 content/browser/webrtc/webrtc_internals.h:112: int num_open_connections() { return num_open_connections_; } Make these ...
4 years, 1 month ago (2016-11-17 18:27:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502413002/60001
4 years, 1 month ago (2016-11-17 18:27:52 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 1 month ago (2016-11-17 18:35:04 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 18:56:18 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/542c74f6d402696e770d70a8716dbcf0ffe53094
Cr-Commit-Position: refs/heads/master@{#432920}

Powered by Google App Engine
This is Rietveld 408576698