[ic] Invalidate prototype validity cell when a slow prototype becomes fast.

[ic] Invalidate prototype validity cell when a slow prototype becomes fast.

BUG=chromium:665886
Committed: https://crrev.com/f718cd1309be2327d1d218560f8663f8b165e4fa
Cr-Commit-Position: refs/heads/master@{#41045}

[Igor Sheludko, 2016-11-16 15:16:15]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 15:16:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-11-16 15:21:03]

ishell@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Igor Sheludko, 2016-11-16 15:21:04]

PTAL

[Jakob Kummerow, 2016-11-16 15:25:28]

lgtm

[Igor Sheludko, 2016-11-16 15:26:33]

The CQ bit was unchecked by ishell@chromium.org

[Igor Sheludko, 2016-11-16 15:26:40]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-11-16 15:26:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-11-16 15:30:19]

The CQ bit was unchecked by ishell@chromium.org

[Igor Sheludko, 2016-11-16 17:03:52]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 17:03:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-11-16 17:10:18]

The CQ bit was unchecked by ishell@chromium.org

[Igor Sheludko, 2016-11-16 17:10:18]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-11-16 17:10:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2502393002/#ps20001
(title: "Added JSObject::NotifyMapChange()")

[commit-bot: I haz the power, 2016-11-16 17:10:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jakob Kummerow, 2016-11-16 17:15:36]

LGTM with nits.

https://codereview.chromium.org/2502393002/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2502393002/diff/20001/src/objects.cc#newcode3575
src/objects.cc:3575: // If this object is a prototype (the callee will check),
invalidate any
nit: outdated comment. I'd just drop it, the method name
"InvalidatePrototypeChains" is descriptive enough.

https://codereview.chromium.org/2502393002/diff/20001/src/objects.cc#newcode3584
src/objects.cc:3584: UpdatePrototypeUserRegistration(old_map, new_map,
new_map->GetIsolate());
nit: s/new_map->GetIsolate()/isolate/

[Igor Sheludko, 2016-11-16 17:15:58]

The CQ bit was unchecked by ishell@chromium.org

[Igor Sheludko, 2016-11-16 17:20:03]

https://codereview.chromium.org/2502393002/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2502393002/diff/20001/src/objects.cc#newcode3575
src/objects.cc:3575: // If this object is a prototype (the callee will check),
invalidate any
On 2016/11/16 17:15:35, Jakob Kummerow wrote:
> nit: outdated comment. I'd just drop it, the method name
> "InvalidatePrototypeChains" is descriptive enough.

Done.

https://codereview.chromium.org/2502393002/diff/20001/src/objects.cc#newcode3584
src/objects.cc:3584: UpdatePrototypeUserRegistration(old_map, new_map,
new_map->GetIsolate());
On 2016/11/16 17:15:35, Jakob Kummerow wrote:
> nit: s/new_map->GetIsolate()/isolate/

Done.

[Igor Sheludko, 2016-11-16 17:20:08]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-11-16 17:20:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2502393002/#ps40001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-11-16 17:20:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 17:44:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 22:36:47]

Description was changed from

==========
[ic] Invalidate prototype validity cell when a slow prototype becomes fast.

BUG=chromium:665886
==========

to

==========
[ic] Invalidate prototype validity cell when a slow prototype becomes fast.

BUG=chromium:665886

Committed: https://crrev.com/f718cd1309be2327d1d218560f8663f8b165e4fa
Cr-Commit-Position: refs/heads/master@{#41045}
==========

[commit-bot: I haz the power, 2016-11-17 22:36:48]

Patchset 3 (id:??) landed as
https://crrev.com/f718cd1309be2327d1d218560f8663f8b165e4fa
Cr-Commit-Position: refs/heads/master@{#41045}