Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4132)

Unified Diff: cc/test/render_pass_test_utils.cc

Issue 2502373003: stop using SkXfermode -- use SkBlendMode instead (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/render_pass_test_utils.h ('k') | cc/test/surface_aggregator_test_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/render_pass_test_utils.cc
diff --git a/cc/test/render_pass_test_utils.cc b/cc/test/render_pass_test_utils.cc
index a8630094d898e20249a5ecc4d07cd2ccb87dbebc..f54217d5033382e9eb3bcfc3530bd03ea22c3f78 100644
--- a/cc/test/render_pass_test_utils.cc
+++ b/cc/test/render_pass_test_utils.cc
@@ -37,14 +37,8 @@ SolidColorDrawQuad* AddQuad(RenderPass* pass,
const gfx::Rect& rect,
SkColor color) {
SharedQuadState* shared_state = pass->CreateAndAppendSharedQuadState();
- shared_state->SetAll(gfx::Transform(),
- rect.size(),
- rect,
- rect,
- false,
- 1,
- SkXfermode::kSrcOver_Mode,
- 0);
+ shared_state->SetAll(gfx::Transform(), rect.size(), rect, rect, false, 1,
+ SkBlendMode::kSrcOver, 0);
SolidColorDrawQuad* quad =
pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>();
quad->SetNew(shared_state, rect, rect, color, false);
@@ -55,14 +49,8 @@ SolidColorDrawQuad* AddClippedQuad(RenderPass* pass,
const gfx::Rect& rect,
SkColor color) {
SharedQuadState* shared_state = pass->CreateAndAppendSharedQuadState();
- shared_state->SetAll(gfx::Transform(),
- rect.size(),
- rect,
- rect,
- true,
- 1,
- SkXfermode::kSrcOver_Mode,
- 0);
+ shared_state->SetAll(gfx::Transform(), rect.size(), rect, rect, true, 1,
+ SkBlendMode::kSrcOver, 0);
SolidColorDrawQuad* quad =
pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>();
quad->SetNew(shared_state, rect, rect, color, false);
@@ -74,14 +62,8 @@ SolidColorDrawQuad* AddTransformedQuad(RenderPass* pass,
SkColor color,
const gfx::Transform& transform) {
SharedQuadState* shared_state = pass->CreateAndAppendSharedQuadState();
- shared_state->SetAll(transform,
- rect.size(),
- rect,
- rect,
- false,
- 1,
- SkXfermode::kSrcOver_Mode,
- 0);
+ shared_state->SetAll(transform, rect.size(), rect, rect, false, 1,
+ SkBlendMode::kSrcOver, 0);
SolidColorDrawQuad* quad =
pass->CreateAndAppendDrawQuad<SolidColorDrawQuad>();
quad->SetNew(shared_state, rect, rect, color, false);
@@ -91,14 +73,8 @@ SolidColorDrawQuad* AddTransformedQuad(RenderPass* pass,
void AddRenderPassQuad(RenderPass* to_pass, RenderPass* contributing_pass) {
gfx::Rect output_rect = contributing_pass->output_rect;
SharedQuadState* shared_state = to_pass->CreateAndAppendSharedQuadState();
- shared_state->SetAll(gfx::Transform(),
- output_rect.size(),
- output_rect,
- output_rect,
- false,
- 1,
- SkXfermode::kSrcOver_Mode,
- 0);
+ shared_state->SetAll(gfx::Transform(), output_rect.size(), output_rect,
+ output_rect, false, 1, SkBlendMode::kSrcOver, 0);
RenderPassDrawQuad* quad =
to_pass->CreateAndAppendDrawQuad<RenderPassDrawQuad>();
quad->SetNew(shared_state, output_rect, output_rect, contributing_pass->id, 0,
@@ -111,7 +87,7 @@ void AddRenderPassQuad(RenderPass* to_pass,
ResourceId mask_resource_id,
const FilterOperations& filters,
gfx::Transform transform,
- SkXfermode::Mode blend_mode) {
+ SkBlendMode blend_mode) {
gfx::Rect output_rect = contributing_pass->output_rect;
SharedQuadState* shared_state = to_pass->CreateAndAppendSharedQuadState();
shared_state->SetAll(transform,
@@ -191,7 +167,7 @@ void AddOneOfEveryQuadType(RenderPass* to_pass,
SharedQuadState* shared_state = to_pass->CreateAndAppendSharedQuadState();
shared_state->SetAll(gfx::Transform(), rect.size(), rect, rect, false, 1,
- SkXfermode::kSrcOver_Mode, 0);
+ SkBlendMode::kSrcOver, 0);
DebugBorderDrawQuad* debug_border_quad =
to_pass->CreateAndAppendDrawQuad<DebugBorderDrawQuad>();
@@ -251,7 +227,7 @@ void AddOneOfEveryQuadType(RenderPass* to_pass,
SharedQuadState* shared_state2 = to_pass->CreateAndAppendSharedQuadState();
shared_state->SetAll(gfx::Transform(), rect.size(), rect, rect, false, 1,
- SkXfermode::kSrcOver_Mode, 0);
+ SkBlendMode::kSrcOver, 0);
TileDrawQuad* tile_quad = to_pass->CreateAndAppendDrawQuad<TileDrawQuad>();
tile_quad->SetNew(shared_state2, rect, opaque_rect, visible_rect, resource4,
« no previous file with comments | « cc/test/render_pass_test_utils.h ('k') | cc/test/surface_aggregator_test_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698