cc/output/overlay_candidate.cc - Issue 2502373003: stop using SkXfermode -- use SkBlendMode instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/overlay_candidate.cc

Issue 2502373003: stop using SkXfermode -- use SkBlendMode instead (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/overlay_candidate.cc

diff --git a/cc/output/overlay_candidate.cc b/cc/output/overlay_candidate.cc

index 5ed4bf493833c34164e67b9d67f817fa01c6a9b7..5e083bde6fd1d47e31d6d0ef141ddfe15e11cd18 100644

--- a/cc/output/overlay_candidate.cc

+++ b/cc/output/overlay_candidate.cc

@@ -187,7 +187,7 @@ bool OverlayCandidate::FromDrawQuad(ResourceProvider* resource_provider,

OverlayCandidate* candidate) {

if (quad->ShouldDrawWithBlending() ||

quad->shared_quad_state->opacity != 1.f ||

- quad->shared_quad_state->blend_mode != SkXfermode::kSrcOver_Mode)

+ quad->shared_quad_state->blend_mode != SkBlendMode::kSrcOver)

return false;

auto& transform = quad->shared_quad_state->quad_to_target_transform;

« no previous file with comments | « cc/output/gl_renderer_unittest.cc ('k') | cc/output/overlay_unittest.cc » ('j') | no next file with comments »