Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: cc/blink/web_display_item_list_impl.cc

Issue 2502373003: stop using SkXfermode -- use SkBlendMode instead (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/blink/web_display_item_list_impl.h ('k') | cc/ipc/cc_param_traits_macros.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/blink/web_display_item_list_impl.h" 5 #include "cc/blink/web_display_item_list_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 transform); 103 transform);
104 } 104 }
105 105
106 void WebDisplayItemListImpl::appendEndTransformItem() { 106 void WebDisplayItemListImpl::appendEndTransformItem() {
107 display_item_list_ 107 display_item_list_
108 ->CreateAndAppendPairedEndItem<cc::EndTransformDisplayItem>(); 108 ->CreateAndAppendPairedEndItem<cc::EndTransformDisplayItem>();
109 } 109 }
110 110
111 void WebDisplayItemListImpl::appendCompositingItem( 111 void WebDisplayItemListImpl::appendCompositingItem(
112 float opacity, 112 float opacity,
113 SkXfermode::Mode xfermode, 113 SkBlendMode xfermode,
114 SkRect* bounds, 114 SkRect* bounds,
115 SkColorFilter* color_filter) { 115 SkColorFilter* color_filter) {
116 DCHECK_GE(opacity, 0.f); 116 DCHECK_GE(opacity, 0.f);
117 DCHECK_LE(opacity, 1.f); 117 DCHECK_LE(opacity, 1.f);
118 // TODO(ajuma): This should really be rounding instead of flooring the alpha 118 // TODO(ajuma): This should really be rounding instead of flooring the alpha
119 // value, but that breaks slimming paint reftests. 119 // value, but that breaks slimming paint reftests.
120 120
121 const bool kLcdTextRequiresOpaqueLayer = true; 121 const bool kLcdTextRequiresOpaqueLayer = true;
122 display_item_list_ 122 display_item_list_
123 ->CreateAndAppendPairedBeginItem<cc::CompositingDisplayItem>( 123 ->CreateAndAppendPairedBeginItem<cc::CompositingDisplayItem>(
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 } 158 }
159 159
160 void WebDisplayItemListImpl::setIsSuitableForGpuRasterization(bool isSuitable) { 160 void WebDisplayItemListImpl::setIsSuitableForGpuRasterization(bool isSuitable) {
161 display_item_list_->SetIsSuitableForGpuRasterization(isSuitable); 161 display_item_list_->SetIsSuitableForGpuRasterization(isSuitable);
162 } 162 }
163 163
164 WebDisplayItemListImpl::~WebDisplayItemListImpl() { 164 WebDisplayItemListImpl::~WebDisplayItemListImpl() {
165 } 165 }
166 166
167 } // namespace cc_blink 167 } // namespace cc_blink
OLDNEW
« no previous file with comments | « cc/blink/web_display_item_list_impl.h ('k') | cc/ipc/cc_param_traits_macros.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698