[wasm] Add the 0x prefix to all constants in PrintAstForDebugging

[wasm] Add the 0x prefix to all constants in PrintAstForDebugging

R=titzer@chromium.org

Committed: https://crrev.com/006041e8d362fe04257aa9d77a1ff12fa37751dd
Cr-Commit-Position: refs/heads/master@{#41048}

[ahaas, 2016-11-16 14:56:10]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 14:56:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-11-16 14:58:28]

https://codereview.chromium.org/2502373002/diff/1/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/2502373002/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:1936: os << " 0x" << AsHex(count, 2) << " " <<
WasmOpcodes::TypeName(type);
I think this one should stay decimal, since it's a count (and can be larger than
a byte).

[commit-bot: I haz the power, 2016-11-16 15:21:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 15:21:41]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-11-16 15:37:24]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 15:37:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-11-16 15:44:47]

https://codereview.chromium.org/2502373002/diff/1/src/wasm/ast-decoder.cc
File src/wasm/ast-decoder.cc (right):

https://codereview.chromium.org/2502373002/diff/1/src/wasm/ast-decoder.cc#new...
src/wasm/ast-decoder.cc:1936: os << " 0x" << AsHex(count, 2) << " " <<
WasmOpcodes::TypeName(type);
On 2016/11/16 at 14:58:28, titzer wrote:
> I think this one should stay decimal, since it's a count (and can be larger
than a byte).

Done

[titzer, 2016-11-16 15:50:49]

lgtm

[commit-bot: I haz the power, 2016-11-16 16:22:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 16:22:17]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-11-16 19:03:19]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-11-16 19:03:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 19:06:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:36:55]

Description was changed from

==========
[wasm] Add the 0x prefix to all constants in PrintAstForDebugging

R=titzer@chromium.org
==========

to

==========
[wasm] Add the 0x prefix to all constants in PrintAstForDebugging

R=titzer@chromium.org

Committed: https://crrev.com/006041e8d362fe04257aa9d77a1ff12fa37751dd
Cr-Commit-Position: refs/heads/master@{#41048}
==========

[commit-bot: I haz the power, 2016-11-17 22:36:56]

Patchset 2 (id:??) landed as
https://crrev.com/006041e8d362fe04257aa9d77a1ff12fa37751dd
Cr-Commit-Position: refs/heads/master@{#41048}