Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 2502363006: [ObjC ARC] Converts ios/chrome/browser/ssl:ssl to ARC.Automatically generated ARCMigrate commitN… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ssl:ssl to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/dc5224607230f80c2e8be3b6b8b9bb8644648770 Cr-Commit-Position: refs/heads/master@{#433569}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M ios/chrome/browser/ssl/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ssl/ios_security_state_tab_helper.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ssl/ios_ssl_blocking_page.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/ssl/ios_ssl_error_handler.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
stkhapugin
PTAL. Passes downstream tests.
4 years, 1 month ago (2016-11-21 13:09:28 UTC) #6
noyau (Ping after 24h)
lgtm
4 years, 1 month ago (2016-11-21 14:27:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502363006/1
4 years, 1 month ago (2016-11-21 15:39:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 16:54:23 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 16:57:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc5224607230f80c2e8be3b6b8b9bb8644648770
Cr-Commit-Position: refs/heads/master@{#433569}

Powered by Google App Engine
This is Rietveld 408576698