Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2502363005: [android] Stop using isolate.py for data dependency management. (RELAND) (Closed)

Created:
4 years, 1 month ago by jbudorick
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke, agrieve
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[android] Stop using isolate.py for data dependency management. (RELAND) BUG=663110 Committed: https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923 Cr-Commit-Position: refs/heads/master@{#433322}

Patch Set 1 #

Patch Set 2 : fixed: moved the runtime_deps file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -829 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M build/android/PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
D build/android/gn/generate_isolate.py View 1 chunk +0 lines, -120 lines 0 comments Download
M build/android/gyp/create_test_runner_script.py View 2 chunks +4 lines, -0 lines 0 comments Download
M build/android/pylib/base/test_instance_factory.py View 1 chunk +3 lines, -3 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 5 chunks +9 lines, -24 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 6 chunks +11 lines, -27 lines 0 comments Download
M build/android/pylib/local/device/local_device_gtest_run.py View 3 chunks +10 lines, -7 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 2 chunks +1 line, -9 lines 0 comments Download
M build/android/pylib/local/device/local_device_test_run.py View 2 chunks +10 lines, -0 lines 0 comments Download
M build/android/pylib/local/device/local_device_test_run_test.py View 1 chunk +28 lines, -0 lines 0 comments Download
A build/android/pylib/utils/device_dependencies.py View 1 chunk +104 lines, -0 lines 0 comments Download
A build/android/pylib/utils/device_dependencies_test.py View 1 chunk +56 lines, -0 lines 0 comments Download
D build/android/pylib/utils/isolator.py View 1 chunk +0 lines, -192 lines 0 comments Download
M build/android/test_runner.py View 2 chunks +12 lines, -4 lines 0 comments Download
M build/android/test_runner.pydeps View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/internal_rules.gni View 1 4 chunks +31 lines, -56 lines 0 comments Download
M build/config/android/rules.gni View 2 chunks +9 lines, -21 lines 0 comments Download
D build/secondary/tools/swarming_client/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D build/secondary/tools/swarming_client/isolate.pydeps View 1 chunk +0 lines, -298 lines 0 comments Download
M testing/test.gni View 5 chunks +23 lines, -49 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbudorick
https://codereview.chromium.org/1914573002/#ps180001 I have no one to blame but myself.
4 years, 1 month ago (2016-11-18 03:10:00 UTC) #2
jbudorick
On 2016/11/18 03:10:00, jbudorick wrote: > https://codereview.chromium.org/1914573002/#ps180001 > > I have no one to blame ...
4 years, 1 month ago (2016-11-18 03:10:44 UTC) #3
Dirk Pranke
lgtm
4 years, 1 month ago (2016-11-18 20:43:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502363005/20001
4 years, 1 month ago (2016-11-18 20:44:55 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 22:46:12 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 22:55:29 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d29ecfa7dc3ed49a2a49002ab941adb57c53e923
Cr-Commit-Position: refs/heads/master@{#433322}

Powered by Google App Engine
This is Rietveld 408576698