Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 2502353003: Paint collapsed borders of a table as one display item (Closed)
Patch Set: - Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 9 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
10 * 10 *
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 125
126 if (!oldStyle) 126 if (!oldStyle)
127 return; 127 return;
128 128
129 LayoutTable* table = this->table(); 129 LayoutTable* table = this->table();
130 if (!table) 130 if (!table)
131 return; 131 return;
132 132
133 if (!table->selfNeedsLayout() && !table->normalChildNeedsLayout() && 133 if (!table->selfNeedsLayout() && !table->normalChildNeedsLayout() &&
134 oldStyle->border() != style()->border()) 134 oldStyle->border() != style()->border())
135 table->invalidateCollapsedBorders(); 135 table->invalidateCollapsedBorders(PaintInvalidationStyleChange);
136 136
137 if (LayoutTableBoxComponent::doCellsHaveDirtyWidth(*this, *table, diff, 137 if (LayoutTableBoxComponent::doCellsHaveDirtyWidth(*this, *table, diff,
138 *oldStyle)) 138 *oldStyle))
139 markAllCellsWidthsDirtyAndOrNeedsLayout( 139 markAllCellsWidthsDirtyAndOrNeedsLayout(
140 LayoutTable::MarkDirtyAndNeedsLayout); 140 LayoutTable::MarkDirtyAndNeedsLayout);
141 } 141 }
142 142
143 void LayoutTableSection::willBeRemovedFromTree() { 143 void LayoutTableSection::willBeRemovedFromTree() {
144 LayoutTableBoxComponent::willBeRemovedFromTree(); 144 LayoutTableBoxComponent::willBeRemovedFromTree();
145 145
(...skipping 1931 matching lines...) Expand 10 before | Expand all | Expand 10 after
2077 // the header in all columns. 2077 // the header in all columns.
2078 // Note that this is in flow thread coordinates, not visual coordinates. The 2078 // Note that this is in flow thread coordinates, not visual coordinates. The
2079 // enclosing LayoutFlowThread will convert to visual coordinates. 2079 // enclosing LayoutFlowThread will convert to visual coordinates.
2080 if (table()->header() == this && isRepeatingHeaderGroup()) 2080 if (table()->header() == this && isRepeatingHeaderGroup())
2081 rect.setHeight(table()->logicalHeight()); 2081 rect.setHeight(table()->logicalHeight());
2082 return LayoutTableBoxComponent::mapToVisualRectInAncestorSpace(ancestor, rect, 2082 return LayoutTableBoxComponent::mapToVisualRectInAncestorSpace(ancestor, rect,
2083 flags); 2083 flags);
2084 } 2084 }
2085 2085
2086 } // namespace blink 2086 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableSection.h ('k') | third_party/WebKit/Source/core/paint/PaintInvalidator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698