Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2502343003: Moved //components/proximity_auth/cryptauth to //components/cryptauth. (Closed)

Created:
4 years, 1 month ago by Kyle Horimoto
Modified:
4 years, 1 month ago
CC:
Ryan Hansberry, chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved //components/proximity_auth/cryptauth to //components/cryptauth. The new CryptAuth component will be shared between ProximityAuth and upcoming tethering code. BUG= Committed: https://crrev.com/999e934c85db04916e04bd39a70dd2fbab19211d Cr-Commit-Position: refs/heads/master@{#433277}

Patch Set 1 #

Patch Set 2 : Prefixed two test names with "CryptAuth" so that they do not collide with other test names. #

Total comments: 2

Patch Set 3 : Update OWNERS files and add description to CryptAuth component BUILD file. #

Patch Set 4 : Fixed proto #includes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+561 lines, -7931 lines) Patch
M chrome/browser/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_challenge_wrapper.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_challenge_wrapper_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/secure_message_delegate_chromeos.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/secure_message_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 1 2 3 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/chrome_proximity_auth_client.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/signin/chrome_proximity_auth_client.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.h View 7 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 7 chunks +16 lines, -16 lines 0 comments Download
M components/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + components/cryptauth/BUILD.gn View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
A + components/cryptauth/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/cryptauth/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + components/cryptauth/cryptauth_access_token_fetcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/cryptauth/cryptauth_access_token_fetcher_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/cryptauth/cryptauth_access_token_fetcher_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/cryptauth/cryptauth_access_token_fetcher_impl_unittest.cc View 7 chunks +9 lines, -9 lines 0 comments Download
A + components/cryptauth/cryptauth_api_call_flow.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/cryptauth/cryptauth_api_call_flow.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/cryptauth/cryptauth_api_call_flow_unittest.cc View 7 chunks +13 lines, -13 lines 0 comments Download
A + components/cryptauth/cryptauth_client.h View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
A + components/cryptauth/cryptauth_client_impl.h View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
A + components/cryptauth/cryptauth_client_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + components/cryptauth/cryptauth_client_impl_unittest.cc View 1 2 3 19 chunks +24 lines, -24 lines 0 comments Download
A + components/cryptauth/cryptauth_device_manager.h View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
A + components/cryptauth/cryptauth_device_manager.cc View 3 chunks +6 lines, -6 lines 0 comments Download
A + components/cryptauth/cryptauth_device_manager_unittest.cc View 18 chunks +23 lines, -23 lines 0 comments Download
A + components/cryptauth/cryptauth_enroller.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + components/cryptauth/cryptauth_enroller_impl.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + components/cryptauth/cryptauth_enroller_impl.cc View 2 chunks +6 lines, -6 lines 0 comments Download
A + components/cryptauth/cryptauth_enroller_impl_unittest.cc View 13 chunks +21 lines, -21 lines 0 comments Download
A + components/cryptauth/cryptauth_enrollment_manager.h View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
A + components/cryptauth/cryptauth_enrollment_manager.cc View 3 chunks +7 lines, -7 lines 0 comments Download
A + components/cryptauth/cryptauth_enrollment_manager_unittest.cc View 15 chunks +21 lines, -21 lines 0 comments Download
A + components/cryptauth/cryptauth_enrollment_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/cryptauth/cryptauth_enrollment_utils.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + components/cryptauth/cryptauth_gcm_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/cryptauth/cryptauth_gcm_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/cryptauth/cryptauth_gcm_manager_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
A + components/cryptauth/cryptauth_gcm_manager_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/cryptauth/cryptauth_gcm_manager_impl_unittest.cc View 10 chunks +16 lines, -16 lines 0 comments Download
A + components/cryptauth/fake_cryptauth_gcm_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/cryptauth/fake_cryptauth_gcm_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/cryptauth/fake_secure_message_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/cryptauth/fake_secure_message_delegate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + components/cryptauth/fake_secure_message_delegate_unittest.cc View 1 6 chunks +10 lines, -10 lines 0 comments Download
A + components/cryptauth/mock_cryptauth_client.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + components/cryptauth/mock_cryptauth_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/cryptauth/mock_sync_scheduler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/cryptauth/mock_sync_scheduler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/cryptauth/pref_names.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/cryptauth/pref_names.cc View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
A + components/cryptauth/proto/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cryptauth/proto/cryptauth_api.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cryptauth/proto/securemessage.proto View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/cryptauth/secure_message_delegate.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + components/cryptauth/secure_message_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/cryptauth/switches.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/cryptauth/switches.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/cryptauth/sync_scheduler.h View 2 chunks +2 lines, -2 lines 0 comments Download
A + components/cryptauth/sync_scheduler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/cryptauth/sync_scheduler_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/cryptauth/sync_scheduler_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + components/cryptauth/sync_scheduler_impl_unittest.cc View 1 19 chunks +22 lines, -22 lines 0 comments Download
M components/proximity_auth/BUILD.gn View 4 chunks +5 lines, -8 lines 0 comments Download
M components/proximity_auth/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/proximity_auth/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/proximity_auth/ble/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/ble/OWNERS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
D components/proximity_auth/cryptauth/BUILD.gn View 1 chunk +0 lines, -106 lines 0 comments Download
D components/proximity_auth/cryptauth/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_access_token_fetcher.h View 1 chunk +0 lines, -30 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_access_token_fetcher_impl.h View 1 chunk +0 lines, -59 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_access_token_fetcher_impl.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_access_token_fetcher_impl_unittest.cc View 1 chunk +0 lines, -76 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_api_call_flow.h View 1 chunk +0 lines, -76 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_api_call_flow.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_api_call_flow_unittest.cc View 1 chunk +0 lines, -153 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_client.h View 1 chunk +0 lines, -115 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_client_impl.h View 1 chunk +0 lines, -150 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_client_impl.cc View 1 chunk +0 lines, -203 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_client_impl_unittest.cc View 1 chunk +0 lines, -562 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_device_manager.h View 1 chunk +0 lines, -171 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_device_manager.cc View 1 chunk +0 lines, -311 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_device_manager_unittest.cc View 1 chunk +0 lines, -609 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_enroller.h View 1 chunk +0 lines, -47 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_enroller_impl.h View 1 chunk +0 lines, -104 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_enroller_impl.cc View 1 chunk +0 lines, -229 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_enroller_impl_unittest.cc View 1 chunk +0 lines, -359 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_enrollment_manager.h View 1 chunk +0 lines, -189 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_enrollment_manager.cc View 1 chunk +0 lines, -304 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_enrollment_manager_unittest.cc View 1 chunk +0 lines, -470 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_enrollment_utils.h View 1 chunk +0 lines, -23 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_enrollment_utils.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_gcm_manager.h View 1 chunk +0 lines, -64 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_gcm_manager.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_gcm_manager_impl.h View 1 chunk +0 lines, -80 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_gcm_manager_impl.cc View 1 chunk +0 lines, -150 lines 0 comments Download
D components/proximity_auth/cryptauth/cryptauth_gcm_manager_impl_unittest.cc View 1 chunk +0 lines, -198 lines 0 comments Download
D components/proximity_auth/cryptauth/fake_cryptauth_gcm_manager.h View 1 chunk +0 lines, -64 lines 0 comments Download
D components/proximity_auth/cryptauth/fake_cryptauth_gcm_manager.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D components/proximity_auth/cryptauth/fake_secure_message_delegate.h View 1 chunk +0 lines, -54 lines 0 comments Download
D components/proximity_auth/cryptauth/fake_secure_message_delegate.cc View 1 chunk +0 lines, -200 lines 0 comments Download
D components/proximity_auth/cryptauth/fake_secure_message_delegate_unittest.cc View 1 chunk +0 lines, -206 lines 0 comments Download
D components/proximity_auth/cryptauth/mock_cryptauth_client.h View 1 chunk +0 lines, -88 lines 0 comments Download
D components/proximity_auth/cryptauth/mock_cryptauth_client.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D components/proximity_auth/cryptauth/mock_sync_scheduler.h View 1 chunk +0 lines, -36 lines 0 comments Download
D components/proximity_auth/cryptauth/mock_sync_scheduler.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D components/proximity_auth/cryptauth/pref_names.h View 1 chunk +0 lines, -25 lines 0 comments Download
D components/proximity_auth/cryptauth/pref_names.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D components/proximity_auth/cryptauth/proto/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
D components/proximity_auth/cryptauth/proto/cryptauth_api.proto View 1 chunk +0 lines, -485 lines 0 comments Download
D components/proximity_auth/cryptauth/proto/securemessage.proto View 1 chunk +0 lines, -116 lines 0 comments Download
D components/proximity_auth/cryptauth/secure_message_delegate.h View 1 chunk +0 lines, -102 lines 0 comments Download
D components/proximity_auth/cryptauth/secure_message_delegate.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D components/proximity_auth/cryptauth/switches.h View 1 chunk +0 lines, -18 lines 0 comments Download
D components/proximity_auth/cryptauth/switches.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D components/proximity_auth/cryptauth/sync_scheduler.h View 1 chunk +0 lines, -98 lines 0 comments Download
D components/proximity_auth/cryptauth/sync_scheduler.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D components/proximity_auth/cryptauth/sync_scheduler_impl.h View 1 chunk +0 lines, -104 lines 0 comments Download
D components/proximity_auth/cryptauth/sync_scheduler_impl.cc View 1 chunk +0 lines, -197 lines 0 comments Download
D components/proximity_auth/cryptauth/sync_scheduler_impl_unittest.cc View 1 chunk +0 lines, -292 lines 0 comments Download
M components/proximity_auth/cryptauth_enroller_factory_impl.h View 2 chunks +4 lines, -3 lines 0 comments Download
M components/proximity_auth/cryptauth_enroller_factory_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M components/proximity_auth/device_to_device_authenticator.h View 3 chunks +9 lines, -6 lines 0 comments Download
M components/proximity_auth/device_to_device_authenticator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/device_to_device_authenticator_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/proximity_auth/device_to_device_initiator_operations.h View 4 chunks +11 lines, -8 lines 0 comments Download
M components/proximity_auth/device_to_device_initiator_operations.cc View 12 chunks +14 lines, -14 lines 0 comments Download
M components/proximity_auth/device_to_device_operations_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/proximity_auth/device_to_device_responder_operations.h View 4 chunks +7 lines, -5 lines 0 comments Download
M components/proximity_auth/device_to_device_responder_operations.cc View 12 chunks +14 lines, -14 lines 0 comments Download
M components/proximity_auth/device_to_device_secure_context.h View 2 chunks +6 lines, -4 lines 0 comments Download
M components/proximity_auth/device_to_device_secure_context.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M components/proximity_auth/device_to_device_secure_context_unittest.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M components/proximity_auth/mock_proximity_auth_client.h View 2 chunks +15 lines, -11 lines 0 comments Download
M components/proximity_auth/mock_proximity_auth_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/proximity_auth/proximity_auth_client.h View 1 2 3 3 chunks +9 lines, -8 lines 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/remote_device_loader.h View 3 chunks +7 lines, -4 lines 0 comments Download
M components/proximity_auth/remote_device_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/proximity_auth/remote_device_loader_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/proximity_auth/webui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/webui/proximity_auth_webui_handler.h View 4 chunks +16 lines, -15 lines 0 comments Download
M components/proximity_auth/webui/proximity_auth_webui_handler.cc View 1 2 3 10 chunks +17 lines, -16 lines 0 comments Download
M components/proximity_auth/webui/reachable_phone_flow.h View 4 chunks +6 lines, -6 lines 0 comments Download
M components/proximity_auth/webui/reachable_phone_flow.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 28 (14 generated)
Kyle Horimoto
4 years, 1 month ago (2016-11-16 22:28:37 UTC) #2
Kyle Horimoto
4 years, 1 month ago (2016-11-16 22:29:27 UTC) #4
Kyle Horimoto
4 years, 1 month ago (2016-11-16 22:30:38 UTC) #8
Tim Song
lgtm
4 years, 1 month ago (2016-11-16 22:37:21 UTC) #9
brettw
LGTM with two updates: You'll want to add an OWNERS file for the new directory. ...
4 years, 1 month ago (2016-11-17 01:17:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502343003/40001
4 years, 1 month ago (2016-11-17 18:52:58 UTC) #13
Kyle Horimoto
On 2016/11/17 01:17:51, brettw (ping on IM after 24h) wrote: > LGTM with two updates: ...
4 years, 1 month ago (2016-11-17 18:54:08 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/334139)
4 years, 1 month ago (2016-11-17 20:10:21 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502343003/60001
4 years, 1 month ago (2016-11-17 22:30:45 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/317528)
4 years, 1 month ago (2016-11-18 01:18:05 UTC) #21
Kyle Horimoto
https://codereview.chromium.org/2502343003/diff/20001/components/cryptauth/BUILD.gn File components/cryptauth/BUILD.gn (right): https://codereview.chromium.org/2502343003/diff/20001/components/cryptauth/BUILD.gn#newcode5 components/cryptauth/BUILD.gn:5: static_library("cryptauth") { On 2016/11/17 01:17:51, brettw (ping on IM ...
4 years, 1 month ago (2016-11-18 01:22:23 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502343003/60001
4 years, 1 month ago (2016-11-18 18:14:12 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-18 20:11:15 UTC) #26
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 20:14:19 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/999e934c85db04916e04bd39a70dd2fbab19211d
Cr-Commit-Position: refs/heads/master@{#433277}

Powered by Google App Engine
This is Rietveld 408576698