Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2252)

Unified Diff: lib/transformations/treeshaker.dart

Issue 2502343002: Store named parameters in sorted lists instead of using maps. (Closed)
Patch Set: Remove duplicates from named parameter lists to recover from erroneous inputs Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/text/ast_to_text.dart ('k') | lib/type_algebra.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/transformations/treeshaker.dart
diff --git a/lib/transformations/treeshaker.dart b/lib/transformations/treeshaker.dart
index 4eb69073b9560f42e824577de7a14eccb6029200..bd33595d2e8885218cb405893a1f59983890d801 100644
--- a/lib/transformations/treeshaker.dart
+++ b/lib/transformations/treeshaker.dart
@@ -757,7 +757,9 @@ class _ExternalTypeVisitor extends DartTypeVisitor {
for (int i = 0; i < node.positionalParameters.length; ++i) {
visitContravariant(node.positionalParameters[i]);
}
- node.namedParameters.values.forEach(visitContravariant);
+ for (int i = 0; i < node.namedParameters.length; ++i) {
+ visitContravariant(node.namedParameters[i].type);
+ }
}
visitTypeParameterType(TypeParameterType node) {}
« no previous file with comments | « lib/text/ast_to_text.dart ('k') | lib/type_algebra.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698