Store named parameters in sorted lists instead of using maps.

Store named parameters in sorted lists instead of using maps.

FunctionType now has a List<NamedType> which must be sorted by name.
Previously, named parameters were stored in a Map<String, DartType>.

FunctionNode still has a List<VariableDeclaration>, but this list must
now be sorted by name.

BUG=
R=ahe@google.com

Committed: https://github.com/dart-lang/kernel/commit/0defa95239024bf36b62f59d42130037cadfa519

[asgerf, 2016-11-16 13:08:36]

asgerf@google.com changed reviewers:
+ ahe@google.com, kmillikin@google.com

[ahe, 2016-11-16 13:21:03]

lgtm

Consider adding a sanity check for this.

https://codereview.chromium.org/2502343002/diff/20001/lib/ast.dart
File lib/ast.dart (right):

https://codereview.chromium.org/2502343002/diff/20001/lib/ast.dart#newcode3382
lib/ast.dart:3382: return name.hashCode * 31 + type.hashCode * 37;
Compute this in constructor?

[asgerf, 2016-11-16 13:38:20]

Added sanity check and expanded the testcase a bit to ensure both sanity checks
can fire.

https://codereview.chromium.org/2502343002/diff/20001/lib/ast.dart
File lib/ast.dart (right):

https://codereview.chromium.org/2502343002/diff/20001/lib/ast.dart#newcode3382
lib/ast.dart:3382: return name.hashCode * 31 + type.hashCode * 37;
On 2016/11/16 13:21:03, ahe wrote:
> Compute this in constructor?

The FunctionType caches its hash code, so there is not much to gain by caching
it here as well.

[ahe, 2016-11-16 13:41:56]

lgtm

https://codereview.chromium.org/2502343002/diff/20001/lib/ast.dart
File lib/ast.dart (right):

https://codereview.chromium.org/2502343002/diff/20001/lib/ast.dart#newcode3382
lib/ast.dart:3382: return name.hashCode * 31 + type.hashCode * 37;
On 2016/11/16 13:38:20, asgerf wrote:
> On 2016/11/16 13:21:03, ahe wrote:
> > Compute this in constructor?
> 
> The FunctionType caches its hash code, so there is not much to gain by caching
> it here as well.

Good point.

[asgerf, 2016-11-16 14:02:52]

PTAL at patch #4. We have to remove duplicates to avoid
the violating the sanity check on erroneous inputs.

[ahe, 2016-11-16 14:06:52]

lgtm

[asgerf, 2016-11-16 14:16:29]

Description was changed from

==========
Store named parameters in sorted lists instead of using maps.

FunctionType now has a List<NamedType> which must be sorted by name.
Previously, named parameters were stored in a Map<String, DartType>.

FunctionNode still has a List<VariableDeclaration>, but this list must
now be sorted by name.

BUG=
==========

to

==========
Store named parameters in sorted lists instead of using maps.

FunctionType now has a List<NamedType> which must be sorted by name.
Previously, named parameters were stored in a Map<String, DartType>.

FunctionNode still has a List<VariableDeclaration>, but this list must
now be sorted by name.

BUG=
R=ahe@google.com

Committed:
https://github.com/dart-lang/kernel/commit/0defa95239024bf36b62f59d42130037ca...
==========

[asgerf, 2016-11-16 14:16:30]

Committed patchset #4 (id:60001) manually as
0defa95239024bf36b62f59d42130037cadfa519 (presubmit successful).