Preparsing inner functions: add regression tests for parameters.

test/mjsunit/fixed-context-shapes-when-recompiling.js

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Flags: --min-preparse-length=1 --allow-natives-syntax --lazy-inner-functions
 
 // Test that the information on which variables to allocate in context doesn't
 // change when recompiling.
 
 (function TestVarInInnerFunction() {
@@ skipping 84 matching lines @@
   for (var i = 0; i < 3; ++i) {
     if (i == 1) {
       %OptimizeOsr();
     }
     assertEquals(1, a);
     assertEquals(2, b);
     assertEquals(3, c);
   }
 })();
 
+(function TestInnerFunctionDestructuredParameter_1() {
+  var a = 1;
+  var b = 2;
+  var c = 3;
+  function inner([d, a]) {
+    a; b; c;
+  }
+  for (var i = 0; i < 3; ++i) {
+    if (i == 1) {
+      %OptimizeOsr();
+    }
+    assertEquals(1, a);
+    assertEquals(2, b);
+    assertEquals(3, c);
+  }
+})();
+
+(function TestInnerFunctionDestructuredParameter_2() {
+  var a = 1;
+  var b = 2;
+  var c = 3;
+  function inner({d, a}) {
+    a; b; c;
+  }
+  for (var i = 0; i < 3; ++i) {
+    if (i == 1) {
+      %OptimizeOsr();
+    }
+    assertEquals(1, a);
+    assertEquals(2, b);
+    assertEquals(3, c);
+  }
+})();
+
+(function TestInnerArrowFunctionParameter() {
+  var a = 1;
+  var b = 2;
+  var c = 3;
+  (a) => { a; b; c; }
+  for (var i = 0; i < 3; ++i) {
+    if (i == 1) {
+      %OptimizeOsr();
+    }
+    assertEquals(1, a);
+    assertEquals(2, b);
+    assertEquals(3, c);
+  }
+})();
+
+(function TestInnerArrowFunctionRestParameter() {
+  var a = 1;
+  var b = 2;
+  var c = 3;
+  (...a) => { a; b; c; }
+  for (var i = 0; i < 3; ++i) {
+    if (i == 1) {
+      %OptimizeOsr();
+    }
+    assertEquals(1, a);
+    assertEquals(2, b);
+    assertEquals(3, c);
+  }
+})();
+
+(function TestInnerArrowFunctionDestructuredParameter_1() {
+  var a = 1;
+  var b = 2;
+  var c = 3;
+  ([d, a]) => { a; b; c; }
+  for (var i = 0; i < 3; ++i) {
+    if (i == 1) {
+      %OptimizeOsr();
+    }
+    assertEquals(1, a);
+    assertEquals(2, b);
+    assertEquals(3, c);
+  }
+})();
+
+(function TestInnerArrowFunctionDestructuredParameter_2() {
+  var a = 1;
+  var b = 2;
+  var c = 3;
+  ({d, a}) => { a; b; c;  }
+  for (var i = 0; i < 3; ++i) {
+    if (i == 1) {
+      %OptimizeOsr();
+    }
+    assertEquals(1, a);
+    assertEquals(2, b);
+    assertEquals(3, c);
+  }
+})();
+
 (function TestInnerInnerFunctionParameter() {
   var a = 1;
   var b = 2;
   var c = 3;
   function inner() {
     function innerinner(a) { a; b; c; }
   }
   for (var i = 0; i < 3; ++i) {
     if (i == 1) {
       %OptimizeOsr();
@@ skipping 14 matching lines @@
   for (var i = 0; i < 3; ++i) {
     if (i == 1) {
       %OptimizeOsr();
     }
     assertEquals(1, a);
     assertEquals(2, b);
     assertEquals(3, c);
   }
 })();
 
-(function TestInnerArrowFunctionParameter() {
+(function TestInnerInnerFunctionDestructuredParameter_1() {
   var a = 1;
   var b = 2;
   var c = 3;
+  function inner() {
+    function innerinner({d, a}) { a; b; c; }
+  }
+  for (var i = 0; i < 3; ++i) {
+    if (i == 1) {
+      %OptimizeOsr();
+    }
+    assertEquals(1, a);
+    assertEquals(2, b);
+    assertEquals(3, c);
+  }
+})();
+
+(function TestInnerInnerFunctionDestructuredParameter_2() {
+  var a = 1;
+  var b = 2;
+  var c = 3;
+  function inner() {
+    function innerinner([d, a]) { a; b; c; }
+  }
+  for (var i = 0; i < 3; ++i) {
+    if (i == 1) {
+      %OptimizeOsr();
+    }
+    assertEquals(1, a);
+    assertEquals(2, b);
+    assertEquals(3, c);
+  }
+})();
+
+(function TestInnerInnerArrowFunctionParameter() {
+  var a = 1;
+  var b = 2;
+  var c = 3;
   function inner() {
     var f = a => a + b + c;
   }
   for (var i = 0; i < 3; ++i) {
     if (i == 1) {
       %OptimizeOsr();
     }
     assertEquals(1, a);
     assertEquals(2, b);
     assertEquals(3, c);
   }
 })();
 
-(function TestInnerArrowFunctionRestParameter() {
+(function TestInnerInnerArrowFunctionRestParameter() {
   var a = 1;
   var b = 2;
   var c = 3;
   function inner() {
     var f = (...a) => a + b + c;
   }
   for (var i = 0; i < 3; ++i) {
     if (i == 1) {
       %OptimizeOsr();
     }
     assertEquals(1, a);
     assertEquals(2, b);
     assertEquals(3, c);
   }
 })();
 
+(function TestInnerInnerArrowFunctionDestructuredParameter_1() {
+  var a = 1;
+  var b = 2;
+  var c = 3;
+  function inner() {
+    var f = ([d, a]) => a + b + c;
+  }
+  for (var i = 0; i < 3; ++i) {
+    if (i == 1) {
+      %OptimizeOsr();
+    }
+    assertEquals(1, a);
+    assertEquals(2, b);
+    assertEquals(3, c);
+  }
+})();
+
+(function TestInnerInnerArrowFunctionDestructuredParameter_2() {
+  var a = 1;
+  var b = 2;
+  var c = 3;
+  function inner() {
+    var f = ({d, a}) => a + b + c;
+  }
+  for (var i = 0; i < 3; ++i) {
+    if (i == 1) {
+      %OptimizeOsr();
+    }
+    assertEquals(1, a);
+    assertEquals(2, b);
+    assertEquals(3, c);
+  }
+})();
+
 (function TestInnerFunctionInnerFunction() {
   var a = 1;
   var b = 2;
   var c = 3;
   function inner() {
     function a() { }
     a; b; c;
   }
   for (var i = 0; i < 3; ++i) {
     if (i == 1) {
@@ skipping 415 matching lines @@
     if (i == 1) {
       %OptimizeOsr();
     }
     var a;
     function inner() {
       const a = 0, b = 0;
     }
   }
 })();
 
-(function TestRegress650969_9() {
+(function TestRegress650969_9_parameter() {
   for (var i = 0; i < 3; ++i) {
     if (i == 1) {
       %OptimizeOsr();
     }
     var a;
-    function inner(a) {
-    }
+    function inner(a) {}
   }
 })();
 
-(function TestRegress650969_10() {
+(function TestRegress650969_9_restParameter() {
   for (var i = 0; i < 3; ++i) {
     if (i == 1) {
       %OptimizeOsr();
     }
     var a;
-    function inner(...a) {
+    function inner(...a) {}
+  }
+})();
+
+(function TestRegress650969_9_destructuredParameter_1() {
+  for (var i = 0; i < 3; ++i) {
+    if (i == 1) {
+      %OptimizeOsr();
+    }
+    var a;
+    function inner([d, a]) {}
+  }
+})();
+
+(function TestRegress650969_9_destructuredParameter_2() {
+  for (var i = 0; i < 3; ++i) {
+    if (i == 1) {
+      %OptimizeOsr();
+    }
+    var a;
+    function inner({d, a}) {}
+  }
+})();
+
+(function TestRegress650969_10_parameter() {
+  for (var i = 0; i < 3; ++i) {
+    if (i == 1) {
+      %OptimizeOsr();
+    }
+    var a;
+    function inner() {
+      function innerinner(a) {}
     }
   }
 })();
+
+(function TestRegress650969_10_restParameter() {
+  for (var i = 0; i < 3; ++i) {
+    if (i == 1) {
+      %OptimizeOsr();
+    }
+    var a;
+    function inner() {
+      function innerinner(...a) {}
+    }
+  }
+})();
+
+(function TestRegress650969_10_destructuredParameter_1() {
+  for (var i = 0; i < 3; ++i) {
+    if (i == 1) {
+      %OptimizeOsr();
+    }
+    var a;
+    function inner() {
+      function innerinner([d, a]) {}
+    }
+  }
+})();
+
+(function TestRegress650969_10_destructuredParameter_2() {
+  for (var i = 0; i < 3; ++i) {
+    if (i == 1) {
+      %OptimizeOsr();
+    }
+    var a;
+    function inner() {
+      function innerinner({d, a}) {}
+    }
+  }
+})();
 
 (function TestRegress650969_11_var() {
   for (var i = 0; i < 3; ++i) {
     if (i == 1) {
       %OptimizeOsr();
     }
     var a;
     function inner() {
       var [a, b] = [1, 2];
     }
@@ skipping 233 matching lines @@
     if (i == 1) {
       %OptimizeOsr();
     }
     var a;
     function inner() {
       for (const a = 0; 0 == 1; ) { }
     }
   }
 })();
 
+(function TestRegress650969_18() {
+  for (var i = 0; i < 3; ++i) {
+    if (i == 1) {
+      %OptimizeOsr();
+    }
+    var a;
+    function inner() {
+      function innerinner([a, b]) {}
+    }
+  }
+})();
+
+(function TestRegress650969_18() {
+  for (var i = 0; i < 3; ++i) {
+    if (i == 1) {
+      %OptimizeOsr();
+    }
+    var a;
+    function inner() {
+      function innerinner(a) {}
+    }
+  }
+})();
+
 // Regression tests for an intermediate stage where unresolved references were
 // discarded too aggressively.
 (function TestRegress650969_sidetrack_var() {
   for (var i = 0; i < 3; ++i) {
     if (i == 1) {
       %OptimizeOsr();
     }
     var a = 0;
     function inner() {
       return a;
@@ skipping 20 matching lines @@
     if (i == 1) {
       %OptimizeOsr();
     }
     var a = 0;
     function inner() {
       return a;
       const {b: {a}, c} = {b: {a: 1}, c: 2};
     }
   }
 })();