Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2502333002: Preparsing inner functions: add regression tests for parameters. (Closed)

Created:
4 years, 1 month ago by marja
Modified:
4 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Preparsing inner functions: add regression tests for parameters. Now that we consistently preparse the parameters of a preparsed function, these no longer crash. BUG=5501 Committed: https://crrev.com/a19b9c8538ad00dc7ee0bd65380bddae5f3b3912 Cr-Commit-Position: refs/heads/master@{#41038}

Patch Set 1 #

Patch Set 2 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -6 lines) Patch
M test/mjsunit/fixed-context-shapes-when-recompiling.js View 1 6 chunks +258 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
marja
ptal
4 years, 1 month ago (2016-11-16 13:27:20 UTC) #6
Toon Verwaest
lgtm
4 years, 1 month ago (2016-11-16 13:34:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502333002/20001
4 years, 1 month ago (2016-11-16 14:21:17 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 14:50:29 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:36:27 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a19b9c8538ad00dc7ee0bd65380bddae5f3b3912
Cr-Commit-Position: refs/heads/master@{#41038}

Powered by Google App Engine
This is Rietveld 408576698