Remove url::ReadUTFChar's dependency on icu. Use base instead.

Remove url::ReadUTFChar's dependency on icu.  Use base instead.

BUG=362608
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267800

[mmenke, 2014-04-24 20:20:31]

The assumption that int == int32 was made in the old code as well:  U8_NEXT
requires begin be an int32, and casts the link to an int32 as well.

A fix would be pretty simple (increment src by begin, set begin to 0, and pass
in min(length-begin, MAX_INT32) as the final parameter), but it's not exactly
pretty.

[mmenke, 2014-04-25 16:12:04]

On 2014/04/24 20:20:31, mmenke wrote:
> The assumption that int == int32 was made in the old code as well:  U8_NEXT
> requires begin be an int32, and casts the link to an int32 as well.
> 
> A fix would be pretty simple (increment src by begin, set begin to 0, and pass
> in min(length-begin, MAX_INT32) as the final parameter), but it's not exactly
> pretty.

Oh, and I should add that I ran the url_unittests with the new code, and they
all passed.

[mmenke, 2014-04-30 17:29:12]

brettw:  Ping!

[+mef]:  Just FYI.

[brettw, 2014-05-01 23:48:14]

lgtm

[mmenke, 2014-05-02 00:22:41]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2014-05-02 00:22:49]

On 2014/05/01 23:48:14, brettw wrote:
> lgtm

Thanks!

[commit-bot: I haz the power, 2014-05-02 00:24:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mmenke@chromium.org/250233002/120001

[commit-bot: I haz the power, 2014-05-02 15:58:35]

Change committed as 267800