Reland of [refactoring] Split CodeAssemblerState out of CodeAssembler

Reland of [refactoring] Split CodeAssemblerState out of CodeAssembler

This is in preparation for introducing more specialized
CodeStubAssembler subclasses. The state object can be handed
around, while the Assembler instances are temporary-scoped.

BUG=v8:5628
Original review: https://codereview.chromium.org/2498073002/

Committed: https://crrev.com/87a65911b95f35d7cbcfd7a5033e367b049b131a
Cr-Commit-Position: refs/heads/master@{#41028}

[Jakob Kummerow, 2016-11-16 09:35:05]

Created Reland of [refactoring] Split CodeAssemblerState out of CodeAssembler

[Jakob Kummerow, 2016-11-16 09:36:22]

Description was changed from

==========
Reland of [refactoring] Split CodeAssemblerState out of CodeAssembler (patchset
#1 id:1 of https://codereview.chromium.org/2504913002/ )

Reason for revert:
Will fix and reland

Original issue's description:
> Revert of [refactoring] Split CodeAssemblerState out of CodeAssembler
(patchset #8 id:140001 of https://codereview.chromium.org/2498073002/ )
> 
> Reason for revert:
> https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared
doesn't want to compile. Missing export annotation?
> 
> Original issue's description:
> > [refactoring] Split CodeAssemblerState out of CodeAssembler
> > 
> > This is in preparation for introducing more specialized
> > CodeStubAssembler subclasses. The state object can be handed
> > around, while the Assembler instances are temporary-scoped.
> > 
> > BUG=v8:5628
> 
> TBR=ishell@chromium.org,mstarzinger@chromium.org,jkummerow@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=v8:5628

TBR=ishell@chromium.org,mstarzinger@chromium.org,machenbach@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5628
==========

to

==========
Reland of [refactoring] Split CodeAssemblerState out of CodeAssembler

This is in preparation for introducing more specialized
CodeStubAssembler subclasses. The state object can be handed
around, while the Assembler instances are temporary-scoped.

BUG=v8:5628

Original review: https://codereview.chromium.org/2498073002/
==========

[Michael Starzinger, 2016-11-16 09:48:56]

LGTM (rubber-stamped, assuming its a plain reland).

[Igor Sheludko, 2016-11-16 10:03:00]

lgtm

[Jakob Kummerow, 2016-11-16 10:55:17]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2016-11-16 10:55:17]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2502293002/#ps300001
(title: "fix")

[commit-bot: I haz the power, 2016-11-16 10:55:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 11:48:17]

Description was changed from

==========
Reland of [refactoring] Split CodeAssemblerState out of CodeAssembler

This is in preparation for introducing more specialized
CodeStubAssembler subclasses. The state object can be handed
around, while the Assembler instances are temporary-scoped.

BUG=v8:5628

Original review: https://codereview.chromium.org/2498073002/
==========

to

==========
Reland of [refactoring] Split CodeAssemblerState out of CodeAssembler

This is in preparation for introducing more specialized
CodeStubAssembler subclasses. The state object can be handed
around, while the Assembler instances are temporary-scoped.

BUG=v8:5628

Original review: https://codereview.chromium.org/2498073002/
==========

[commit-bot: I haz the power, 2016-11-16 11:48:18]

Committed patchset #2 (id:300001)

[Michael Achenbach, 2016-11-17 08:24:33]

A revert of this CL (patchset #2 id:300001) has been created in
https://codereview.chromium.org/2507203003/ by machenbach@chromium.org.

The reason for reverting is: Blocks roll:
https://codereview.chromium.org/2502363002/
Bisected locally. See e.g.:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium....

[Michael Achenbach, 2016-11-17 08:26:39]

On 2016/11/17 08:24:33, machenbach (OOO) wrote:
> A revert of this CL (patchset #2 id:300001) has been created in
> https://codereview.chromium.org/2507203003/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: Blocks roll:
> https://codereview.chromium.org/2502363002/
> Bisected locally. See e.g.:
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium....

Looks like only two trybots on the chromium CQ use the "all" target, which
includes our unittests. Therefore this was not detected on our chromium bots.

Bonus points: Would be nice to find out why we link unittests differently in a
chromium context. It should be the same as in v8 standalone.

[Michael Achenbach, 2016-11-17 08:52:49]

On 2016/11/17 08:26:39, machenbach (slow) wrote:
> On 2016/11/17 08:24:33, machenbach (OOO) wrote:
> > A revert of this CL (patchset #2 id:300001) has been created in
> > https://codereview.chromium.org/2507203003/ by
mailto:machenbach@chromium.org.
> > 
> > The reason for reverting is: Blocks roll:
> > https://codereview.chromium.org/2502363002/
> > Bisected locally. See e.g.:
> >
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium....
> 
> Looks like only two trybots on the chromium CQ use the "all" target, which
> includes our unittests. Therefore this was not detected on our chromium bots.
> 
> Bonus points: Would be nice to find out why we link unittests differently in a
> chromium context. It should be the same as in v8 standalone.

Keeping this. Landing fix instead.

[commit-bot: I haz the power, 2016-11-17 22:35:56]

Description was changed from

==========
Reland of [refactoring] Split CodeAssemblerState out of CodeAssembler

This is in preparation for introducing more specialized
CodeStubAssembler subclasses. The state object can be handed
around, while the Assembler instances are temporary-scoped.

BUG=v8:5628

Original review: https://codereview.chromium.org/2498073002/
==========

to

==========
Reland of [refactoring] Split CodeAssemblerState out of CodeAssembler

This is in preparation for introducing more specialized
CodeStubAssembler subclasses. The state object can be handed
around, while the Assembler instances are temporary-scoped.

BUG=v8:5628

Original review: https://codereview.chromium.org/2498073002/

Committed: https://crrev.com/87a65911b95f35d7cbcfd7a5033e367b049b131a
Cr-Commit-Position: refs/heads/master@{#41028}
==========

[commit-bot: I haz the power, 2016-11-17 22:35:58]

Patchset 2 (id:??) landed as
https://crrev.com/87a65911b95f35d7cbcfd7a5033e367b049b131a
Cr-Commit-Position: refs/heads/master@{#41028}