runtime/observatory/lib/src/repositories/top_retaining_instances.dart - Issue 2502283003: Add a version of heap snapshots that use only fields and stack frames as roots and only include ins…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/repositories/top_retaining_instances.dart

Issue 2502283003: Add a version of heap snapshots that use only fields and stack frames as roots and only include ins… (Closed)

Patch Set: . Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/lib/src/repositories/heap_snapshot.dart ('k') | runtime/observatory/lib/src/service/object.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/lib/src/repositories/top_retaining_instances.dart

diff --git a/runtime/observatory/lib/src/repositories/top_retaining_instances.dart b/runtime/observatory/lib/src/repositories/top_retaining_instances.dart

index 00947622496e783a81bbff5e049b4bf552971823..400ac1427ed1638b870eaf8c3ea1ee6cd7f9fea1 100644

--- a/runtime/observatory/lib/src/repositories/top_retaining_instances.dart

+++ b/runtime/observatory/lib/src/repositories/top_retaining_instances.dart

@@ -11,7 +11,8 @@ class TopRetainingInstancesRepository

S.Class cls = c as S.Class;

assert(isolate != null);

assert(cls != null);

- final raw = await isolate.fetchHeapSnapshot(true).last;

+ final raw =

+ await isolate.fetchHeapSnapshot(M.HeapSnapshotRoots.vm, true).last;

final snapshot = new HeapSnapshot();

await snapshot.loadProgress(isolate, raw).last;

return (await Future.wait(

« no previous file with comments | « runtime/observatory/lib/src/repositories/heap_snapshot.dart ('k') | runtime/observatory/lib/src/service/object.dart » ('j') | no next file with comments »