Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2502253006: VM: Fix regexp_test.cc after IRRegExpMacroAssembler::Execute signature chages. (Closed)

Created:
4 years, 1 month ago by Vyacheslav Egorov (Google)
Modified:
4 years, 1 month ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Fix regexp_test.cc after IRRegExpMacroAssembler::Execute signature chages. Pass sticky=false to Execute. TBR=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/1a570da155849fc322d583316c72ef9d36dc7903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M runtime/vm/regexp_test.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
4 years, 1 month ago (2016-11-17 16:56:18 UTC) #1
Vyacheslav Egorov (Google)
Committed patchset #1 (id:1) manually as 1a570da155849fc322d583316c72ef9d36dc7903 (presubmit successful).
4 years, 1 month ago (2016-11-17 16:56:29 UTC) #3
rmacnak
4 years, 1 month ago (2016-11-17 18:01:53 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698