Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2502253003: [Sync] Move GenerateSyncableHash to base. (Closed)

Created:
4 years, 1 month ago by maxbogue
Modified:
4 years, 1 month ago
Reviewers:
pavely
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Move GenerateSyncableHash to base. It's not only used by directory, so it doesn't make sense to live in syncable. BUG=637950 Committed: https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06 Cr-Commit-Position: refs/heads/master@{#432937}

Patch Set 1 #

Patch Set 2 : Keep full syncable/ DEP. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -158 lines) Patch
M components/sync/BUILD.gn View 3 chunks +3 lines, -1 line 0 comments Download
A components/sync/base/hash_util.h View 1 chunk +27 lines, -0 lines 0 comments Download
A components/sync/base/hash_util.cc View 1 chunk +35 lines, -0 lines 0 comments Download
A + components/sync/base/hash_util_unittest.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M components/sync/engine_impl/loopback_server/persistent_unique_client_entity.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M components/sync/engine_impl/model_type_worker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/engine_impl/sync_manager_impl_unittest.cc View 20 chunks +19 lines, -32 lines 0 comments Download
M components/sync/engine_impl/syncer_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/sync/engine_impl/test_entry_factory.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M components/sync/engine_impl/uss_migrator_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M components/sync/engine_impl/worker_entity_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/model/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/model/fake_model_type_sync_bridge.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/sync/model_impl/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M components/sync/model_impl/processor_entity_tracker.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/model_impl/processor_entity_tracker_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/model_impl/shared_model_type_processor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/syncable/directory_backing_store.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M components/sync/syncable/model_neutral_mutable_entry.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/syncable/mutable_entry.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/syncable/parent_child_index_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/syncable/read_node.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/syncable/syncable_util.h View 2 chunks +0 lines, -14 lines 0 comments Download
M components/sync/syncable/syncable_util.cc View 2 chunks +0 lines, -24 lines 0 comments Download
D components/sync/syncable/syncable_util_unittest.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M components/sync/syncable/write_node.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M components/sync/test/fake_server/bookmark_entity_builder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/test/fake_server/unique_client_entity.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync_sessions/sessions_sync_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
maxbogue
Sky, PTAL!
4 years, 1 month ago (2016-11-16 19:53:40 UTC) #4
maxbogue
Actually, when the change processor classes get moved to model/ they'll bring a ton of ...
4 years, 1 month ago (2016-11-16 23:31:24 UTC) #8
maxbogue
Reassigning since Sky is out sick; Pavel PTAL!
4 years, 1 month ago (2016-11-17 18:15:34 UTC) #14
pavely
lgtm
4 years, 1 month ago (2016-11-17 19:16:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502253003/20001
4 years, 1 month ago (2016-11-17 19:34:24 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 20:08:05 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 20:28:55 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2b0bb91030096c9241d50ec723f63d0f19906b06
Cr-Commit-Position: refs/heads/master@{#432937}

Powered by Google App Engine
This is Rietveld 408576698