Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Issue 2502243002: Support multiple Observer instances for ArcSupportHost. (Closed)

Created:
4 years, 1 month ago by hidehiko
Modified:
4 years, 1 month ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, khmel+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, khmel
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support multiple Observer instances for ArcSupportHost. ArcAuthService will be split into smaller pieces, and split classes need to communicate with ArcSupportHost. To support such a situation, this CL introduces base::ObserverList into ArcSupportHost. BUG=657687 BUG=b/31079732 TEST=Ran on test device. Ran bots. Committed: https://crrev.com/685dd76fbc10e816e880286a43c1487ac6dcf60b Cr-Commit-Position: refs/heads/master@{#432867}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -23 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_support_host.h View 1 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_support_host.cc View 1 4 chunks +21 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
hidehiko
PTAL.
4 years, 1 month ago (2016-11-16 05:04:04 UTC) #2
Luis Héctor Chávez
lgtm
4 years, 1 month ago (2016-11-16 05:07:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502243002/20001
4 years, 1 month ago (2016-11-17 14:06:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 14:35:45 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 14:37:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/685dd76fbc10e816e880286a43c1487ac6dcf60b
Cr-Commit-Position: refs/heads/master@{#432867}

Powered by Google App Engine
This is Rietveld 408576698