report errors in included options files

report errors in included options files

Example error messages include:
/analysis_options.yaml(10..27): The include file other_options.yaml in /analysis_options.yaml cannot be found.
/analysis_options.yaml(10..27): Bad options file format (expected String scope key, got YamlScalar) in /other_options.yaml(0..0)
/analysis_options.yaml(10..27): Warning in the included options file /other_options.yaml(47..49): The option 'ftw' isn't supported by 'errors'.

Since the included options file may not be part of the project,
the error is reported on the initial include statement
and includes the needed location information for the user to track down the problem.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/0d15f1d892afebc7bc1186857f3eeb585406b692

[danrubel, 2016-11-16 23:07:45]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-11-17 00:46:50]

lgtm

[danrubel, 2016-11-17 19:43:10]

Description was changed from

==========
report errors in included options files

Example error messages include:
/analysis_options.yaml(10..27): The include file other_options.yaml in
/analysis_options.yaml cannot be found.
/analysis_options.yaml(10..27): Bad options file format (expected String scope
key, got YamlScalar) in /other_options.yaml(0..0)
/analysis_options.yaml(10..27): Warning in the included options file
/other_options.yaml(47..49): The option 'ftw' isn't supported by 'errors'.

Since the included options file may not be part of the project,
the error is reported on the initial include statement
and includes the needed location information for the user to track down the
problem.
==========

to

==========
report errors in included options files

Example error messages include:
/analysis_options.yaml(10..27): The include file other_options.yaml in
/analysis_options.yaml cannot be found.
/analysis_options.yaml(10..27): Bad options file format (expected String scope
key, got YamlScalar) in /other_options.yaml(0..0)
/analysis_options.yaml(10..27): Warning in the included options file
/other_options.yaml(47..49): The option 'ftw' isn't supported by 'errors'.

Since the included options file may not be part of the project,
the error is reported on the initial include statement
and includes the needed location information for the user to track down the
problem.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0d15f1d892afebc7bc1186857f3eeb585406b692
==========

[danrubel, 2016-11-17 19:43:11]

Committed patchset #2 (id:20001) manually as
0d15f1d892afebc7bc1186857f3eeb585406b692 (presubmit successful).