Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 250223002: Ignore ERROR_ADDRESS_NOT_ASSOCIATED from IpReleaseAddress in WiFiService::ResetDHCP. (Closed)

Created:
6 years, 8 months ago by mef
Modified:
6 years, 8 months ago
Reviewers:
afontan, tbarzic
CC:
chromium-reviews
Visibility:
Public.

Description

Ignore ERROR_ADDRESS_NOT_ASSOCIATED from IpReleaseAddress in WiFiService::ResetDHCP. It is reported on Win 8.1 running on MS Surface Pro after connection to factory-reset Chromecast device. BUG=366582 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266117

Patch Set 1 #

Total comments: 6

Patch Set 2 : rebase and format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -27 lines) Patch
M components/wifi/wifi_service_win.cc View 1 4 chunks +18 lines, -7 lines 0 comments Download
M components/wifi/wifi_test.cc View 1 8 chunks +35 lines, -20 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
mef
Hi guys, please take a look. Toni, did you enter a crbug for this? Antonio, ...
6 years, 8 months ago (2014-04-23 20:31:41 UTC) #1
tbarzic
I haven't created crbug.. feel free to do so.. lgtm https://codereview.chromium.org/250223002/diff/1/components/wifi/wifi_test.cc File components/wifi/wifi_test.cc (right): https://codereview.chromium.org/250223002/diff/1/components/wifi/wifi_test.cc#newcode61 ...
6 years, 8 months ago (2014-04-23 20:53:55 UTC) #2
afontan
lgtm https://codereview.chromium.org/250223002/diff/1/components/wifi/wifi_service_win.cc File components/wifi/wifi_service_win.cc (right): https://codereview.chromium.org/250223002/diff/1/components/wifi/wifi_service_win.cc#newcode908 components/wifi/wifi_service_win.cc:908: LOG(ERROR) << error; You are logging it twice ...
6 years, 8 months ago (2014-04-23 21:04:16 UTC) #3
mef
Thanks! I'll wait for https://codereview.chromium.org/249683002/ to land and then commit this one. https://codereview.chromium.org/250223002/diff/1/components/wifi/wifi_service_win.cc File components/wifi/wifi_service_win.cc ...
6 years, 8 months ago (2014-04-23 21:41:22 UTC) #4
mef
The CQ bit was checked by mef@chromium.org
6 years, 8 months ago (2014-04-24 11:27:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/250223002/20001
6 years, 8 months ago (2014-04-24 11:31:19 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 12:14:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 12:14:55 UTC) #8
mef
The CQ bit was checked by mef@chromium.org
6 years, 8 months ago (2014-04-24 14:24:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/250223002/20001
6 years, 8 months ago (2014-04-24 14:25:37 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 15:47:13 UTC) #11
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=135456
6 years, 8 months ago (2014-04-24 15:47:14 UTC) #12
mef
The CQ bit was checked by mef@chromium.org
6 years, 8 months ago (2014-04-25 01:27:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mef@chromium.org/250223002/20001
6 years, 8 months ago (2014-04-25 01:33:00 UTC) #14
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 03:19:18 UTC) #15
Message was sent while issue was closed.
Change committed as 266117

Powered by Google App Engine
This is Rietveld 408576698