Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2502223002: Custom Elements: The 'is' Attribute Should Not Be Specified on an Autonomous Custom Element (Closed)

Created:
4 years, 1 month ago by yurak
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added some tests according to https://html.spec.whatwg.org/multipage/scripting.html#custom-elements-core-concepts Fixed a bug where: The 'is' attribute must not be specified on an autonomous custom element, if it is it has no effect BUG=666166 Committed: https://crrev.com/f7888049506013dd915e6d9cbd03bbe837ccf271 Cr-Commit-Position: refs/heads/master@{#433451}

Patch Set 1 #

Patch Set 2 : If an is attribute is defined when creating an autonomous custom element, it is ignored #

Patch Set 3 : edits made to follow specs more closely #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -15 lines) Patch
M third_party/WebKit/LayoutTests/custom-elements/spec/create-element.html View 1 2 6 chunks +26 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp View 1 2 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
yurak
PTL
4 years, 1 month ago (2016-11-16 02:46:15 UTC) #3
dominicc (has gone to gerrit)
LGTM, nice tests. Could you file a crbug and put it in the BUG= line ...
4 years, 1 month ago (2016-11-17 01:29:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502223002/20001
4 years, 1 month ago (2016-11-19 09:42:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/109210)
4 years, 1 month ago (2016-11-19 09:44:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502223002/40001
4 years, 1 month ago (2016-11-20 08:44:24 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-20 08:51:17 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-20 08:54:25 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f7888049506013dd915e6d9cbd03bbe837ccf271
Cr-Commit-Position: refs/heads/master@{#433451}

Powered by Google App Engine
This is Rietveld 408576698