[inspector] removed embbeder debugger script flag

[inspector] removed embbeder debugger script flag

After moving inspector from blink to V8, inspector can use DebugInterface to compile and mark internal scripts.

BUG=v8:5530
R=yangguo@chromium.org

Committed: https://crrev.com/afd49054ac89d36060a9cdb250e400583513e2ac
Cr-Commit-Position: refs/heads/master@{#41087}

[kozy, 2016-11-16 01:06:55]

Yang, please take a look.

I'll remove ScriptOrigin constructor with resource_embedder_debugger_script flag
after migrating blink to new cstor.

[kozy, 2016-11-16 01:07:56]

Description was changed from

==========
[inspector] remove embbeder debugger script flag

After moving inspector from blink to V8, inspector can use DebugInterface to
compile and mark internal scripts.

BUG=v8:5530
R=yangguo@chromium.org
==========

to

==========
[inspector] removed embbeder debugger script flag

After moving inspector from blink to V8, inspector can use DebugInterface to
compile and mark internal scripts.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=v8:5530
R=yangguo@chromium.org
==========

[Yang, 2016-11-16 07:56:47]

lgtm

https://codereview.chromium.org/2502173002/diff/1/src/inspector/v8-debugger.cc
File src/inspector/v8-debugger.cc (right):

https://codereview.chromium.org/2502173002/diff/1/src/inspector/v8-debugger.c...
src/inspector/v8-debugger.cc:591: if (script->IsInspectorScript()) return;
Can we filter at v8::internal::Debug::OnAfterCompile instead? I.e. only trigger
the event for Script::TYPE_NORMAL scripts?

[kozy, 2016-11-17 16:18:28]

all done, thanks!

https://codereview.chromium.org/2502173002/diff/1/src/inspector/v8-debugger.cc
File src/inspector/v8-debugger.cc (right):

https://codereview.chromium.org/2502173002/diff/1/src/inspector/v8-debugger.c...
src/inspector/v8-debugger.cc:591: if (script->IsInspectorScript()) return;
On 2016/11/16 07:56:47, Yang wrote:
> Can we filter at v8::internal::Debug::OnAfterCompile instead? I.e. only
trigger
> the event for Script::TYPE_NORMAL scripts?

Done.

[kozy, 2016-11-17 16:18:32]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-11-17 16:18:32]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2502173002/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-11-17 16:18:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 16:20:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 16:20:48]

Try jobs failed on following builders:
  linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_precise_blink_rel/...)

[kozy, 2016-11-17 16:38:00]

Description was changed from

==========
[inspector] removed embbeder debugger script flag

After moving inspector from blink to V8, inspector can use DebugInterface to
compile and mark internal scripts.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
BUG=v8:5530
R=yangguo@chromium.org
==========

to

==========
[inspector] removed embbeder debugger script flag

After moving inspector from blink to V8, inspector can use DebugInterface to
compile and mark internal scripts.

BUG=v8:5530
R=yangguo@chromium.org
==========

[kozy, 2016-11-17 16:38:54]

linux_precise_blink_rel failure is not related to this change. I checked locally
that tests are prepared on blink side.

[kozy, 2016-11-17 16:38:59]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-11-17 16:39:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 16:50:48]

Description was changed from

==========
[inspector] removed embbeder debugger script flag

After moving inspector from blink to V8, inspector can use DebugInterface to
compile and mark internal scripts.

BUG=v8:5530
R=yangguo@chromium.org
==========

to

==========
[inspector] removed embbeder debugger script flag

After moving inspector from blink to V8, inspector can use DebugInterface to
compile and mark internal scripts.

BUG=v8:5530
R=yangguo@chromium.org
==========

[commit-bot: I haz the power, 2016-11-17 16:50:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:38:48]

Description was changed from

==========
[inspector] removed embbeder debugger script flag

After moving inspector from blink to V8, inspector can use DebugInterface to
compile and mark internal scripts.

BUG=v8:5530
R=yangguo@chromium.org
==========

to

==========
[inspector] removed embbeder debugger script flag

After moving inspector from blink to V8, inspector can use DebugInterface to
compile and mark internal scripts.

BUG=v8:5530
R=yangguo@chromium.org

Committed: https://crrev.com/afd49054ac89d36060a9cdb250e400583513e2ac
Cr-Commit-Position: refs/heads/master@{#41087}
==========

[commit-bot: I haz the power, 2016-11-17 22:38:49]

Patchset 2 (id:??) landed as
https://crrev.com/afd49054ac89d36060a9cdb250e400583513e2ac
Cr-Commit-Position: refs/heads/master@{#41087}