Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2502163002: Better text for link to Gittiles-flavored Markdown. (Closed)

Created:
4 years, 1 month ago by pwnall
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Better text for link to Gittiles-flavored Markdown. The current link text makes it seem like it would point to a generic Markdown guide. The updated text makes it clearer that the link is worth following, even if the reader already knows Markdown. BUG= Committed: https://crrev.com/3f9183878c552cafda8d0b02e2724b6cb86660c4 Cr-Commit-Position: refs/heads/master@{#432533}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed feedback = fixed typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M docs/README.md View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
pwnall
WDYT?
4 years, 1 month ago (2016-11-16 00:30:19 UTC) #2
Dirk Pranke
lgtm
4 years, 1 month ago (2016-11-16 00:35:33 UTC) #4
qyearsley
LGTM, now I know what "*** aside", "*** note", and "*** promo" do :-) https://codereview.chromium.org/2502163002/diff/1/docs/README.md ...
4 years, 1 month ago (2016-11-16 00:39:24 UTC) #5
pwnall
On 2016/11/16 00:39:24, qyearsley wrote: > LGTM, now I know what "*** aside", "*** note", ...
4 years, 1 month ago (2016-11-16 01:01:30 UTC) #6
pwnall
Thank you very much for the review and quick turnaround! https://codereview.chromium.org/2502163002/diff/1/docs/README.md File docs/README.md (right): https://codereview.chromium.org/2502163002/diff/1/docs/README.md#newcode4 ...
4 years, 1 month ago (2016-11-16 01:01:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502163002/20001
4 years, 1 month ago (2016-11-16 01:02:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502163002/20001
4 years, 1 month ago (2016-11-16 17:15:38 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 17:22:49 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 17:48:53 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3f9183878c552cafda8d0b02e2724b6cb86660c4
Cr-Commit-Position: refs/heads/master@{#432533}

Powered by Google App Engine
This is Rietveld 408576698