Chromium Code Reviews
DescriptionRevert of [chromecast] Make testnames consistent. (patchset #6 id:100001 of https://codereview.chromium.org/2499563002/ )
Reason for revert:
This broke the cast_shell_linux builder, because gn_isolate_map.pyl was not updated correctly, causing the analyze step to fail, e.g.:
https://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/261305/steps/analyze/logs/stdio
Unfortunately, because the //testing files (and some of the BUILD.gn files) were changed, we bypassed the actual analyze invocation, so we didn't notice this in the try jobs.
Original issue's description:
> [chromecast] Make testnames consistent.
>
> Note that cast_shell_tests were not being run on the bots. This patch
> moves it into a top-level cast_shell_unittests target.
>
> BUG=665489
> TBR=dpranke,sky
>
> Committed: https://crrev.com/98afc7db00a7bfe749914e4d618ccb9cc76cbb97
> Cr-Commit-Position: refs/heads/master@{#432225}
TBR=derekjchow@chromium.org,halliwell@chromium.org,alokp@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=665489
Committed: https://crrev.com/9f25f76c28650c6d27dbdc972cf0027516066a2a
Cr-Commit-Position: refs/heads/master@{#432290}
Patch Set 1 #Messages
Total messages: 7 (3 generated)
|