Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2502143002: Revert of [chromecast] Make testnames consistent. (Closed)

Created:
4 years, 1 month ago by Dirk Pranke
Modified:
4 years, 1 month ago
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, pfeldman, halliwell+watch_chromium.org, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [chromecast] Make testnames consistent. (patchset #6 id:100001 of https://codereview.chromium.org/2499563002/ ) Reason for revert: This broke the cast_shell_linux builder, because gn_isolate_map.pyl was not updated correctly, causing the analyze step to fail, e.g.: https://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/261305/steps/analyze/logs/stdio Unfortunately, because the //testing files (and some of the BUILD.gn files) were changed, we bypassed the actual analyze invocation, so we didn't notice this in the try jobs. Original issue's description: > [chromecast] Make testnames consistent. > > Note that cast_shell_tests were not being run on the bots. This patch > moves it into a top-level cast_shell_unittests target. > > BUG=665489 > TBR=dpranke,sky > > Committed: https://crrev.com/98afc7db00a7bfe749914e4d618ccb9cc76cbb97 > Cr-Commit-Position: refs/heads/master@{#432225} TBR=derekjchow@chromium.org,halliwell@chromium.org,alokp@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=665489 Committed: https://crrev.com/9f25f76c28650c6d27dbdc972cf0027516066a2a Cr-Commit-Position: refs/heads/master@{#432290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+870 lines, -819 lines) Patch
M chromecast/BUILD.gn View 4 chunks +5 lines, -26 lines 0 comments Download
M chromecast/app/BUILD.gn View 2 chunks +3 lines, -17 lines 0 comments Download
M chromecast/app/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D chromecast/app/cast_test_launcher.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M chromecast/browser/BUILD.gn View 2 chunks +46 lines, -28 lines 0 comments Download
D chromecast/browser/cast_media_blocker_browsertest.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D chromecast/browser/cast_media_blocker_unittest.cc View 1 chunk +0 lines, -281 lines 0 comments Download
D chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc View 1 chunk +0 lines, -84 lines 0 comments Download
M chromecast/browser/test/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
D chromecast/browser/test/cast_browser_test.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chromecast/browser/test/cast_browser_test.cc View 1 chunk +0 lines, -80 lines 0 comments Download
A chromecast/browser/test/cast_devtools_delegate_test.cc View 1 chunk +82 lines, -0 lines 0 comments Download
A chromecast/browser/test/cast_media_blocker_test.cc View 1 chunk +275 lines, -0 lines 0 comments Download
D chromecast/browser/test/cast_navigation_browsertest.cc View 1 chunk +0 lines, -90 lines 0 comments Download
A chromecast/browser/test/cast_test_launcher.cc View 1 chunk +55 lines, -0 lines 0 comments Download
A chromecast/browser/test/chromecast_browser_test.h View 1 chunk +50 lines, -0 lines 0 comments Download
A chromecast/browser/test/chromecast_browser_test.cc View 1 chunk +71 lines, -0 lines 0 comments Download
A chromecast/browser/test/chromecast_browser_test_runner.cc View 1 chunk +70 lines, -0 lines 0 comments Download
A chromecast/browser/test/chromecast_shell_browser_test.cc View 1 chunk +93 lines, -0 lines 0 comments Download
A chromecast/browser/test/chromecast_shell_media_blocking_browser_test.cc View 1 chunk +108 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Dirk Pranke
Created Revert of [chromecast] Make testnames consistent.
4 years, 1 month ago (2016-11-15 23:39:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502143002/1
4 years, 1 month ago (2016-11-15 23:39:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 23:41:13 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 23:44:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f25f76c28650c6d27dbdc972cf0027516066a2a
Cr-Commit-Position: refs/heads/master@{#432290}

Powered by Google App Engine
This is Rietveld 408576698