Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2502103003: Change BazelWorkspace so that it checks the main source directory before READONLY. (Closed)

Created:
4 years, 1 month ago by Paul Berry
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change BazelWorkspace so that it checks the main source directory before READONLY. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/7336101b28496f37771223f85135d5ecf7def787

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M pkg/analyzer/lib/src/generated/bazel.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/bazel_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 1 month ago (2016-11-15 23:07:21 UTC) #2
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-15 23:20:20 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 7336101b28496f37771223f85135d5ecf7def787 (presubmit successful).
4 years, 1 month ago (2016-11-15 23:21:51 UTC) #5
scheglov
4 years, 1 month ago (2016-11-16 02:39:42 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698