Add FIDO U2F message and packet classes

device/u2f/u2f_message_unittest.cc

Index: device/u2f/u2f_message_unittest.cc
diff --git a/device/u2f/u2f_message_unittest.cc b/device/u2f/u2f_message_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a965edccc2211cecfa010430629c89a8e2115b7f
--- /dev/null
+++ b/device/u2f/u2f_message_unittest.cc
@@ -0,0 +1,198 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "device/u2f/u2f_message.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class U2fMessageTest : public testing::Test {};
+
+// Packets should be 64 bytes + 1 report ID byte
+TEST_F(U2fMessageTest, TestPacketSize) {
+  uint8_t channel_id[4] = {5, 6, 7, 8};
+  std::vector<uint8_t> data;
+
+  scoped_refptr<device::U2fPacket> init_packet(
+      new device::U2fInitPacket(channel_id, 0, data, data.size()));
+  EXPECT_EQ(65, init_packet->GetBuffer()->size());
+
+  scoped_refptr<device::U2fPacket> continuation_packet(
+      new device::U2fContPacket(channel_id, 0, data));
+  EXPECT_EQ(65, continuation_packet->GetBuffer()->size());
+}
+
+/*
+ * U2f Init Packets are of the format:
+ * Byte 0:    0
+ * Byte 1-4:  Channel ID
+ * Byte 5:    Command byte
+ * Byte 6-7:  Big Endian size of data
+ * Byte 8-n:  Data block
+ *
+ * Remaining buffer is padded with 0
+ */
+TEST_F(U2fMessageTest, TestPacketData) {
+  uint8_t channel_id[4] = {5, 6, 7, 8};
+  std::vector<uint8_t> data{10, 11};
+  uint8_t cmd = static_cast<uint8_t>(device::U2fMessage::Type::CMD_WINK);
+  scoped_refptr<device::U2fPacket> init_packet(
+      new device::U2fInitPacket(channel_id, cmd, data, data.size()));
+  int index = 0;
+
+  EXPECT_EQ(0, init_packet->GetBuffer()->data()[index++]);
+  EXPECT_EQ(channel_id[0], init_packet->GetBuffer()->data()[index++]);
+  EXPECT_EQ(channel_id[1], init_packet->GetBuffer()->data()[index++]);
+  EXPECT_EQ(channel_id[2], init_packet->GetBuffer()->data()[index++]);
+  EXPECT_EQ(channel_id[3], init_packet->GetBuffer()->data()[index++]);
+  EXPECT_EQ((char)cmd, init_packet->GetBuffer()->data()[index++]);
+
+  EXPECT_EQ((char)(data.size() >> 8),
+            init_packet->GetBuffer()->data()[index++]);
+  EXPECT_EQ((char)(data.size() & 0xff),
+            init_packet->GetBuffer()->data()[index++]);
+  EXPECT_EQ(data.at(0), init_packet->GetBuffer()->data()[index++]);
+  EXPECT_EQ(data.at(1), init_packet->GetBuffer()->data()[index++]);
+  for (; index < init_packet->GetBuffer()->size(); index++) {
+    EXPECT_EQ(0, init_packet->GetBuffer()->data()[index])
+        << "mismatch at index " << index;
+  }
+}
+
+TEST_F(U2fMessageTest, TestPacketConstructors) {
+  uint8_t channel_id[4] = {5, 6, 7, 8};
+  std::vector<uint8_t> data{10, 11};
+  uint8_t cmd = static_cast<uint8_t>(device::U2fMessage::Type::CMD_WINK);
+  scoped_refptr<device::U2fInitPacket> orig_packet(
+      new device::U2fInitPacket(channel_id, cmd, data, data.size()));
+
+  size_t payload_length = static_cast<size_t>(orig_packet->GetPayloadLength());
+  scoped_refptr<device::U2fInitPacket> reconstructed_packet =
+      device::U2fInitPacket::Create(orig_packet->GetBuffer(), &payload_length);
+  EXPECT_EQ(orig_packet->GetCommand(), reconstructed_packet->GetCommand());
+  EXPECT_EQ(orig_packet->GetPayloadLength(),
+            reconstructed_packet->GetPayloadLength());
+  EXPECT_TRUE(orig_packet->GetData() == reconstructed_packet->GetData());
+
+  for (size_t i = 0; i < device::U2fPacket::kChannelIdSize; ++i)
+    EXPECT_EQ(orig_packet->GetChannelId()[i],
+              reconstructed_packet->GetChannelId()[i]);

[Reilly Grant (use Gerrit), 2016/12/07 22:33:48]

nit: Braces around loop body when it is multiple lines.

[Casey Piper, 2016/12/09 00:15:54]

Done.

+
+  ASSERT_EQ(orig_packet->GetBuffer()->size(),
+            reconstructed_packet->GetBuffer()->size());
+  for (size_t i = 0; i < static_cast<size_t>(orig_packet->GetBuffer()->size());
+       ++i)
+    EXPECT_EQ(orig_packet->GetBuffer()->data()[i],
+              reconstructed_packet->GetBuffer()->data()[i]);

[Reilly Grant (use Gerrit), 2016/12/07 22:33:48]

nit: Braces around loop body when it is multiple lines.

[Casey Piper, 2016/12/09 00:15:54]

Done.

+}
+
+TEST_F(U2fMessageTest, TestMaxLengthPacketConstructors) {
+  uint8_t channel_id[4] = {0xAA, 0xAB, 0xAC, 0xAD};
+  std::vector<uint8_t> data;
+  for (size_t i = 0; i < device::U2fMessage::kMaxMessageSize; ++i)
+    data.push_back(static_cast<uint8_t>(i % 0xff));
+
+  device::U2fMessage::Type cmd = device::U2fMessage::Type::CMD_MSG;
+  scoped_refptr<device::U2fMessage> orig_msg =
+      device::U2fMessage::Create(channel_id, cmd, data);
+  std::list<scoped_refptr<device::U2fPacket>>::const_iterator it =
+      orig_msg->begin();
+  scoped_refptr<device::U2fMessage> new_msg =
+      device::U2fMessage::Create((*it)->GetBuffer());
+  it++;
+
+  for (; it != orig_msg->end(); ++it)
+    new_msg->AddContPacket((*it)->GetBuffer());
+
+  std::list<scoped_refptr<device::U2fPacket>>::const_iterator orig_it =
+      orig_msg->begin();
+  std::list<scoped_refptr<device::U2fPacket>>::const_iterator new_it =
+      new_msg->begin();
+
+  for (; orig_it != orig_msg->end() && new_it != new_msg->end();
+       ++orig_it, ++new_it) {
+    EXPECT_TRUE((*orig_it)->GetData() == (*new_it)->GetData());
+    if ((*orig_it)->GetData() != (*new_it)->GetData()) {
+      printf("%d:%d \n", (int)(*orig_it)->GetData().size(),

[Reilly Grant (use Gerrit), 2016/12/07 22:33:48]

Please avoid printfs in tests. You can use EXPECT_EQ(foo) << "foo" << foo type
statements to have more context logged on failure.

[Casey Piper, 2016/12/09 00:15:54]

Done.

+             (int)(*new_it)->GetData().size());
+      for (size_t i = 0; i < static_cast<size_t>((*orig_it)->GetData().size());
+           ++i) {
+        printf("%x:%x ", (*orig_it)->GetData().at(i),
+               (*orig_it)->GetData().at(i));
+      }
+    }
+
+    for (size_t i = 0; i < device::U2fPacket::kChannelIdSize; ++i)
+      EXPECT_EQ((*orig_it)->GetChannelId()[i], (*new_it)->GetChannelId()[i]);
+
+    ASSERT_EQ((*orig_it)->GetBuffer()->size(), (*new_it)->GetBuffer()->size());
+    for (size_t i = 0; i < static_cast<size_t>((*new_it)->GetBuffer()->size());
+         ++i) {
+      EXPECT_EQ((*orig_it)->GetBuffer()->data()[i],
+                (*new_it)->GetBuffer()->data()[i]);
+    }
+  }
+}
+
+TEST_F(U2fMessageTest, TestMessagePartioning) {
+  uint8_t channel_id[4] = {1, 1, 2, 3};
+  std::vector<uint8_t> data(device::U2fMessage::kInitPacketDataSize + 1);
+  scoped_refptr<device::U2fMessage> two_packet_message =
+      device::U2fMessage::Create(channel_id, device::U2fMessage::Type::CMD_PING,
+                                 data);
+  EXPECT_EQ(2U, two_packet_message->NumPackets());
+
+  data.resize(device::U2fMessage::kInitPacketDataSize);
+  scoped_refptr<device::U2fMessage> one_packet_message =
+      device::U2fMessage::Create(channel_id, device::U2fMessage::Type::CMD_PING,
+                                 data);
+  EXPECT_EQ(1U, one_packet_message->NumPackets());
+
+  data.resize(device::U2fMessage::kInitPacketDataSize +
+              device::U2fMessage::kContPacketDataSize + 1);
+  scoped_refptr<device::U2fMessage> three_packet_message =
+      device::U2fMessage::Create(channel_id, device::U2fMessage::Type::CMD_PING,
+                                 data);
+  EXPECT_EQ(3U, three_packet_message->NumPackets());
+}
+
+TEST_F(U2fMessageTest, TestMaxSize) {
+  uint8_t channel_id[4] = {0, 1, 2, 3};
+  std::vector<uint8_t> data(device::U2fMessage::kMaxMessageSize + 1);
+  scoped_refptr<device::U2fMessage> oversize_message =
+      device::U2fMessage::Create(channel_id, device::U2fMessage::Type::CMD_PING,
+                                 data);
+  EXPECT_EQ(nullptr, oversize_message);
+}
+
+TEST_F(U2fMessageTest, TestDeconstruct) {
+  uint8_t channel_id[4] = {0xA, 0xB, 0xC, 0xD};
+  std::vector<uint8_t> data(device::U2fMessage::kMaxMessageSize);
+  std::fill(std::begin(data), std::end(data), 0x7F);
+  scoped_refptr<device::U2fMessage> filled_message = device::U2fMessage::Create(
+      channel_id, device::U2fMessage::Type::CMD_PING, data);
+
+  EXPECT_TRUE(data == filled_message->GetData());

[Reilly Grant (use Gerrit), 2016/12/07 22:33:48]

You can use EXPECT_THAT(data, ContainerEq(filled_message->GetData()) from gmock
to do comparisons between vectors.

[Casey Piper, 2016/12/09 00:15:54]

Done.

+}
+
+TEST_F(U2fMessageTest, TestDeserialize) {
+  uint8_t channel_id[4] = {0xA, 0xB, 0xC, 0xD};
+  std::vector<uint8_t> data(device::U2fMessage::kMaxMessageSize);
+
+  scoped_refptr<device::U2fMessage> orig_message = device::U2fMessage::Create(
+      channel_id, device::U2fMessage::Type::CMD_PING, data);
+  std::list<scoped_refptr<net::IOBufferWithSize>> orig_list;
+  scoped_refptr<net::IOBufferWithSize> buf = orig_message->PopNextPacket();
+  orig_list.push_back(buf);
+
+  scoped_refptr<device::U2fMessage> new_message =
+      device::U2fMessage::Create(buf);
+  while ((buf = orig_message->PopNextPacket())) {
+    orig_list.push_back(buf);
+    new_message->AddContPacket(buf);
+  }
+
+  while ((buf = new_message->PopNextPacket())) {
+    EXPECT_TRUE(buf == orig_list.front());
+    orig_list.pop_front();
+  }
+}