Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Side by Side Diff: device/u2f/u2f_message_unittest.cc

Issue 2502103002: Add FIDO U2F message and packet classes (Closed)
Patch Set: Change channel id to uint32_t from uint8_t[4] and fix additional review comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "device/u2f/u2f_message.h"
6 #include "testing/gmock/include/gmock/gmock.h"
7 #include "testing/gtest/include/gtest/gtest.h"
8
9 namespace device {
10
11 class U2fMessageTest : public testing::Test {
12 public:
13 U2fMessageTest() {}
14 };
15
16 // Packets should be 64 bytes + 1 report ID byte
17 TEST_F(U2fMessageTest, TestPacketSize) {
18 uint32_t channel_id = 0x05060708;
19 std::vector<uint8_t> data;
20
21 scoped_refptr<U2fPacket> init_packet(
22 new U2fInitPacket(channel_id, 0, data, data.size()));
23 EXPECT_EQ(65, init_packet->GetSerializedBuffer()->size());
24
25 scoped_refptr<U2fPacket> continuation_packet(
26 new U2fContinuationPacket(channel_id, 0, data));
27 EXPECT_EQ(65, continuation_packet->GetSerializedBuffer()->size());
28 }
29
30 /*
31 * U2f Init Packets are of the format:
32 * Byte 0: 0
33 * Byte 1-4: Channel ID
34 * Byte 5: Command byte
35 * Byte 6-7: Big Endian size of data
36 * Byte 8-n: Data block
37 *
38 * Remaining buffer is padded with 0
39 */
40 TEST_F(U2fMessageTest, TestPacketData) {
41 uint32_t channel_id = 0xF5060708;
42 std::vector<uint8_t> data{10, 11};
43 uint8_t cmd = static_cast<uint8_t>(U2fMessage::Type::CMD_WINK);
44 scoped_refptr<U2fPacket> init_packet(
45 new U2fInitPacket(channel_id, cmd, data, data.size()));
46 int index = 0;
47
48 EXPECT_EQ(0, init_packet->GetSerializedBuffer()->data()[index++]);
49 EXPECT_EQ((channel_id >> 24) & 0xff,
50 static_cast<uint8_t>(
51 init_packet->GetSerializedBuffer()->data()[index++]));
52 EXPECT_EQ((channel_id >> 16) & 0xff,
53 static_cast<uint8_t>(
54 init_packet->GetSerializedBuffer()->data()[index++]));
55 EXPECT_EQ((channel_id >> 8) & 0xff,
56 static_cast<uint8_t>(
57 init_packet->GetSerializedBuffer()->data()[index++]));
58 EXPECT_EQ(channel_id & 0xff,
59 static_cast<uint8_t>(
60 init_packet->GetSerializedBuffer()->data()[index++]));
61 EXPECT_EQ(cmd, static_cast<uint8_t>(
62 init_packet->GetSerializedBuffer()->data()[index++]));
63
64 EXPECT_EQ(data.size() >> 8,
65 static_cast<uint8_t>(
66 init_packet->GetSerializedBuffer()->data()[index++]));
67 EXPECT_EQ(data.size() & 0xff,
68 static_cast<uint8_t>(
69 init_packet->GetSerializedBuffer()->data()[index++]));
70 EXPECT_EQ(data.at(0), init_packet->GetSerializedBuffer()->data()[index++]);
71 EXPECT_EQ(data.at(1), init_packet->GetSerializedBuffer()->data()[index++]);
72 for (; index < init_packet->GetSerializedBuffer()->size(); index++) {
73 EXPECT_EQ(0, init_packet->GetSerializedBuffer()->data()[index])
74 << "mismatch at index " << index;
75 }
76 }
77
78 TEST_F(U2fMessageTest, TestPacketConstructors) {
79 uint32_t channel_id = 0x05060708;
80 std::vector<uint8_t> data{10, 11};
81 uint8_t cmd = static_cast<uint8_t>(U2fMessage::Type::CMD_WINK);
82 scoped_refptr<U2fInitPacket> orig_packet(
83 new U2fInitPacket(channel_id, cmd, data, data.size()));
84
85 size_t payload_length = static_cast<size_t>(orig_packet->GetPayloadLength());
86 scoped_refptr<U2fInitPacket> reconstructed_packet =
87 U2fInitPacket::CreateFromSerializedData(
88 orig_packet->GetSerializedBuffer(), &payload_length);
89 EXPECT_EQ(orig_packet->GetCommand(), reconstructed_packet->GetCommand());
90 EXPECT_EQ(orig_packet->GetPayloadLength(),
91 reconstructed_packet->GetPayloadLength());
92 EXPECT_THAT(orig_packet->GetPacketPayload(),
93 testing::ContainerEq(reconstructed_packet->GetPacketPayload()));
94
95 EXPECT_EQ(channel_id, reconstructed_packet->GetChannelId());
96
97 ASSERT_EQ(orig_packet->GetSerializedBuffer()->size(),
98 reconstructed_packet->GetSerializedBuffer()->size());
99 for (size_t i = 0;
100 i < static_cast<size_t>(orig_packet->GetSerializedBuffer()->size());
101 ++i) {
102 EXPECT_EQ(orig_packet->GetSerializedBuffer()->data()[i],
103 reconstructed_packet->GetSerializedBuffer()->data()[i]);
104 }
105 }
106
107 TEST_F(U2fMessageTest, TestMaxLengthPacketConstructors) {
108 uint32_t channel_id = 0xAAABACAD;
109 std::vector<uint8_t> data;
110 for (size_t i = 0; i < U2fMessage::kMaxMessageSize; ++i)
111 data.push_back(static_cast<uint8_t>(i % 0xff));
112
113 U2fMessage::Type cmd = U2fMessage::Type::CMD_MSG;
114 scoped_refptr<U2fMessage> orig_msg =
115 U2fMessage::Create(channel_id, cmd, data);
116 std::list<scoped_refptr<U2fPacket>>::const_iterator it = orig_msg->begin();
117 scoped_refptr<U2fMessage> new_msg =
118 U2fMessage::CreateFromSerializedData((*it)->GetSerializedBuffer());
119 it++;
120
121 for (; it != orig_msg->end(); ++it)
122 new_msg->AddContinuationPacket((*it)->GetSerializedBuffer());
123
124 std::list<scoped_refptr<U2fPacket>>::const_iterator orig_it =
125 orig_msg->begin();
126 std::list<scoped_refptr<U2fPacket>>::const_iterator new_it = new_msg->begin();
127
128 for (; orig_it != orig_msg->end() && new_it != new_msg->end();
129 ++orig_it, ++new_it) {
130 EXPECT_THAT((*orig_it)->GetPacketPayload(),
131 testing::ContainerEq((*new_it)->GetPacketPayload()));
132
133 EXPECT_EQ((*orig_it)->GetChannelId(), (*new_it)->GetChannelId());
134
135 ASSERT_EQ((*orig_it)->GetSerializedBuffer()->size(),
136 (*new_it)->GetSerializedBuffer()->size());
137 for (size_t i = 0;
138 i < static_cast<size_t>((*new_it)->GetSerializedBuffer()->size());
139 ++i) {
140 EXPECT_EQ((*orig_it)->GetSerializedBuffer()->data()[i],
141 (*new_it)->GetSerializedBuffer()->data()[i]);
142 }
143 }
144 }
145
146 TEST_F(U2fMessageTest, TestMessagePartioning) {
Reilly Grant (use Gerrit) 2016/12/09 01:19:43 Partitioning?
Casey Piper 2016/12/09 18:56:50 Done.
147 uint32_t channel_id = 0x01010203;
148 std::vector<uint8_t> data(U2fMessage::kInitPacketDataSize + 1);
149 scoped_refptr<U2fMessage> two_packet_message =
150 U2fMessage::Create(channel_id, U2fMessage::Type::CMD_PING, data);
151 EXPECT_EQ(2U, two_packet_message->NumPackets());
152
153 data.resize(U2fMessage::kInitPacketDataSize);
154 scoped_refptr<U2fMessage> one_packet_message =
155 U2fMessage::Create(channel_id, U2fMessage::Type::CMD_PING, data);
156 EXPECT_EQ(1U, one_packet_message->NumPackets());
157
158 data.resize(U2fMessage::kInitPacketDataSize +
159 U2fMessage::kContinuationPacketDataSize + 1);
160 scoped_refptr<U2fMessage> three_packet_message =
161 U2fMessage::Create(channel_id, U2fMessage::Type::CMD_PING, data);
162 EXPECT_EQ(3U, three_packet_message->NumPackets());
163 }
164
165 TEST_F(U2fMessageTest, TestMaxSize) {
166 uint32_t channel_id = 0x00010203;
167 std::vector<uint8_t> data(U2fMessage::kMaxMessageSize + 1);
168 scoped_refptr<U2fMessage> oversize_message =
169 U2fMessage::Create(channel_id, U2fMessage::Type::CMD_PING, data);
170 EXPECT_EQ(nullptr, oversize_message);
171 }
172
173 TEST_F(U2fMessageTest, TestDeconstruct) {
174 uint32_t channel_id = 0x0A0B0C0D;
175 std::vector<uint8_t> data(U2fMessage::kMaxMessageSize);
176 std::fill(std::begin(data), std::end(data), 0x7F);
177 scoped_refptr<U2fMessage> filled_message =
178 U2fMessage::Create(channel_id, U2fMessage::Type::CMD_PING, data);
179
180 EXPECT_THAT(data, testing::ContainerEq(filled_message->GetMessagePayload()));
181 }
182
183 TEST_F(U2fMessageTest, TestDeserialize) {
184 uint32_t channel_id = 0x0A0B0C0D;
185 std::vector<uint8_t> data(U2fMessage::kMaxMessageSize);
186
187 scoped_refptr<U2fMessage> orig_message =
188 U2fMessage::Create(channel_id, U2fMessage::Type::CMD_PING, data);
189 std::list<scoped_refptr<net::IOBufferWithSize>> orig_list;
190 scoped_refptr<net::IOBufferWithSize> buf = orig_message->PopNextPacket();
191 orig_list.push_back(buf);
192
193 scoped_refptr<U2fMessage> new_message =
194 U2fMessage::CreateFromSerializedData(buf);
195 while ((buf = orig_message->PopNextPacket())) {
196 orig_list.push_back(buf);
197 new_message->AddContinuationPacket(buf);
198 }
199
200 while ((buf = new_message->PopNextPacket())) {
201 ASSERT_EQ(buf->size(), orig_list.front()->size());
202 EXPECT_EQ(0, memcmp(buf->data(), orig_list.front()->data(), buf->size()));
203 orig_list.pop_front();
204 }
205 }
206 } // namespace device
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698