Issue 25021006: Add GrSurface::savePixels().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25021006: Add GrSurface::savePixels(). (Closed)

Created:
7 years, 2 months ago by jvanverth1

Modified:
7 years, 2 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add GrSurface::savePixels(). Committed: http://code.google.com/p/skia/source/detail?r=11528

Patch Set 2 : Remove unnecessary ref to GrDrawState #

Patch Set 3 : Remove unnecessary #include #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
	M	include/gpu/GrSurface.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	src/gpu/GrSurface.cpp	View	1 2	1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bsalomon

lgtm w/ one question https://codereview.chromium.org/25021006/diff/1/src/gpu/GrSurface.cpp File src/gpu/GrSurface.cpp (right): https://codereview.chromium.org/25021006/diff/1/src/gpu/GrSurface.cpp#newcode29 src/gpu/GrSurface.cpp:29: remove(filename); is this cross-platform?

7 years, 2 months ago (2013-09-30 17:39:04 UTC) #2

jvanverth1

https://codereview.chromium.org/25021006/diff/1/src/gpu/GrSurface.cpp File src/gpu/GrSurface.cpp (right): https://codereview.chromium.org/25021006/diff/1/src/gpu/GrSurface.cpp#newcode29 src/gpu/GrSurface.cpp:29: remove(filename); On 2013/09/30 17:39:04, bsalomon wrote: > is this ...

7 years, 2 months ago (2013-09-30 17:46:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/25021006/9001

7 years, 2 months ago (2013-09-30 17:56:00 UTC) #4

Message was sent while issue was closed.

Change committed as 11528