Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Side by Side Diff: media/filters/video_renderer_algorithm_unittest.cc

Issue 2502093002: Adjust VideoRendererAlgorithm for |frame_dropping_disabled_| (Closed)
Patch Set: Style fixes, new unit test Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/filters/video_renderer_algorithm.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include <cmath> 8 #include <cmath>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 700 matching lines...) Expand 10 before | Expand all | Expand 10 after
711 frame = RenderAndStep(&tg, &frames_dropped); 711 frame = RenderAndStep(&tg, &frames_dropped);
712 ASSERT_FALSE(is_using_cadence()); 712 ASSERT_FALSE(is_using_cadence());
713 ASSERT_TRUE(frame); 713 ASSERT_TRUE(frame);
714 EXPECT_EQ(0u, frames_dropped); 714 EXPECT_EQ(0u, frames_dropped);
715 EXPECT_EQ(tg.interval(3), frame->timestamp()); 715 EXPECT_EQ(tg.interval(3), frame->timestamp());
716 EXPECT_EQ(0u, EffectiveFramesQueued()); 716 EXPECT_EQ(0u, EffectiveFramesQueued());
717 EXPECT_EQ(1u, frames_queued()); 717 EXPECT_EQ(1u, frames_queued());
718 EXPECT_EQ(96, algorithm_.GetMemoryUsage()); 718 EXPECT_EQ(96, algorithm_.GetMemoryUsage());
719 } 719 }
720 720
721 TEST_F(VideoRendererAlgorithmTest, EffectiveFramesQueuedWithoutFrameDropping) {
722 TickGenerator tg(tick_clock_->NowTicks(), 50);
723
724 algorithm_.disable_frame_dropping();
725
726 ASSERT_EQ(0u, EffectiveFramesQueued());
727 time_source_.StartTicking();
728
729 for (size_t i = 0; i < 3; ++i) {
730 algorithm_.EnqueueFrame(CreateFrame(tg.interval(i)));
731 EXPECT_EQ(i + 1, EffectiveFramesQueued());
732 EXPECT_EQ(i + 1, frames_queued());
733 }
734
735 // Issue a render call and verify that undropped frames remain effective.
736 tg.step(2);
737 size_t frames_dropped = 0;
738 scoped_refptr<VideoFrame> frame = RenderAndStep(&tg, &frames_dropped);
739 ASSERT_NE(nullptr, frame);
740 EXPECT_EQ(tg.interval(0), frame->timestamp());
741 EXPECT_EQ(0u, frames_dropped);
742 EXPECT_EQ(2u, EffectiveFramesQueued());
743
744 // As the next frame is consumed, the count of effective frames is
745 // decremented.
746 frame = RenderAndStep(&tg, &frames_dropped);
747 ASSERT_NE(nullptr, frame);
748 EXPECT_EQ(tg.interval(1), frame->timestamp());
749 EXPECT_EQ(0u, frames_dropped);
750 EXPECT_EQ(1u, EffectiveFramesQueued());
751 }
752
721 // The maximum acceptable drift should be updated once we have two frames. 753 // The maximum acceptable drift should be updated once we have two frames.
722 TEST_F(VideoRendererAlgorithmTest, AcceptableDriftUpdated) { 754 TEST_F(VideoRendererAlgorithmTest, AcceptableDriftUpdated) {
723 TickGenerator tg(tick_clock_->NowTicks(), 50); 755 TickGenerator tg(tick_clock_->NowTicks(), 50);
724 756
725 size_t frames_dropped = 0; 757 size_t frames_dropped = 0;
726 const base::TimeDelta original_drift = max_acceptable_drift(); 758 const base::TimeDelta original_drift = max_acceptable_drift();
727 algorithm_.EnqueueFrame(CreateFrame(tg.interval(0))); 759 algorithm_.EnqueueFrame(CreateFrame(tg.interval(0)));
728 EXPECT_EQ(1u, frames_queued()); 760 EXPECT_EQ(1u, frames_queued());
729 EXPECT_TRUE(RenderAndStep(&tg, &frames_dropped)); 761 EXPECT_TRUE(RenderAndStep(&tg, &frames_dropped));
730 EXPECT_EQ(original_drift, max_acceptable_drift()); 762 EXPECT_EQ(original_drift, max_acceptable_drift());
(...skipping 801 matching lines...) Expand 10 before | Expand all | Expand 10 after
1532 ASSERT_TRUE(is_using_cadence()); 1564 ASSERT_TRUE(is_using_cadence());
1533 1565
1534 // Finally the last frame. 1566 // Finally the last frame.
1535 rendered_frame = RenderAndStep(&tg, &frames_dropped); 1567 rendered_frame = RenderAndStep(&tg, &frames_dropped);
1536 EXPECT_EQ(1u, frames_queued()); 1568 EXPECT_EQ(1u, frames_queued());
1537 EXPECT_EQ(tg.interval(12), rendered_frame->timestamp()); 1569 EXPECT_EQ(tg.interval(12), rendered_frame->timestamp());
1538 ASSERT_TRUE(is_using_cadence()); 1570 ASSERT_TRUE(is_using_cadence());
1539 } 1571 }
1540 1572
1541 } // namespace media 1573 } // namespace media
OLDNEW
« no previous file with comments | « media/filters/video_renderer_algorithm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698