Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2502063002: [Extensions] Add missing include (Closed)

Created:
4 years, 1 month ago by Devlin
Modified:
4 years, 1 month ago
Reviewers:
nasko
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Add missing include Fix failure from crrev.com/2097de33a1f3d04e78d93e9e2f16aad4b97e47d7 BUG=665517 BUG=660498 NOTRY=true (cast_shell_linux flaking out of control) Committed: https://crrev.com/6c0d227bc9eae0114258f6ad1e00973dda4d424d Cr-Commit-Position: refs/heads/master@{#432274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/extensions/api/tabs/tabs_api_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
Devlin
4 years, 1 month ago (2016-11-15 20:39:34 UTC) #4
nasko
LGTM
4 years, 1 month ago (2016-11-15 20:39:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502063002/1
4 years, 1 month ago (2016-11-15 20:44:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/260978)
4 years, 1 month ago (2016-11-15 21:00:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502063002/1
4 years, 1 month ago (2016-11-15 21:14:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/261035)
4 years, 1 month ago (2016-11-15 21:29:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502063002/1
4 years, 1 month ago (2016-11-15 22:05:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502063002/1
4 years, 1 month ago (2016-11-15 22:15:48 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 22:35:07 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 22:40:05 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c0d227bc9eae0114258f6ad1e00973dda4d424d
Cr-Commit-Position: refs/heads/master@{#432274}

Powered by Google App Engine
This is Rietveld 408576698