Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 2502003002: [ios] Adds a helper function to register prefs for Physical Web. (Closed)

Created:
4 years, 1 month ago by rohitrao (ping after 24h)
Modified:
4 years, 1 month ago
Reviewers:
mattreynolds
CC:
chromium-reviews, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds a helper function to register prefs for Physical Web. BUG=662936 Committed: https://crrev.com/8992184387c35c2aec09fdead0a46ea71ff46189 Cr-Commit-Position: refs/heads/master@{#432776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M ios/chrome/browser/physical_web/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
A ios/chrome/browser/physical_web/physical_web_prefs_registration.h View 1 chunk +16 lines, -0 lines 0 comments Download
A ios/chrome/browser/physical_web/physical_web_prefs_registration.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
rohitrao (ping after 24h)
I'm adding this function but not calling it from anywhere because avoiding duplicate prefs registration ...
4 years, 1 month ago (2016-11-15 16:05:02 UTC) #4
mattreynolds
On 2016/11/15 16:05:02, rohitrao wrote: > I'm adding this function but not calling it from ...
4 years, 1 month ago (2016-11-16 18:53:04 UTC) #7
mattreynolds
lgtm
4 years, 1 month ago (2016-11-16 19:14:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502003002/1
4 years, 1 month ago (2016-11-16 21:26:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/69159)
4 years, 1 month ago (2016-11-16 22:48:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502003002/1
4 years, 1 month ago (2016-11-16 22:55:46 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/316375)
4 years, 1 month ago (2016-11-17 02:09:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502003002/1
4 years, 1 month ago (2016-11-17 02:17:52 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 05:58:39 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 06:03:36 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8992184387c35c2aec09fdead0a46ea71ff46189
Cr-Commit-Position: refs/heads/master@{#432776}

Powered by Google App Engine
This is Rietveld 408576698