Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: components/nacl/loader/BUILD.gn

Issue 2501913002: Change the NaCl loader and broker processes to use the ServiceManager. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/loader/BUILD.gn
diff --git a/components/nacl/loader/BUILD.gn b/components/nacl/loader/BUILD.gn
index f0da685997a84b1caa05a32920a6bbbfcd7dd758..f193e9a230f237e3f27bdef4cfc27e0634f315d0 100644
--- a/components/nacl/loader/BUILD.gn
+++ b/components/nacl/loader/BUILD.gn
@@ -4,6 +4,7 @@
import("//build/config/features.gni")
import("//build/config/nacl/config.gni")
+import("//services/service_manager/public/service_manifest.gni")
import("//testing/test.gni")
assert(enable_nacl)
@@ -38,6 +39,7 @@ source_set("minimal") {
"//ppapi/c",
"//ppapi/proxy:ipc",
"//sandbox",
+ "//services/service_manager/public/cpp",
]
}
@@ -49,10 +51,7 @@ source_set("minimal_content_dummy") {
check_includes = false
sources = [
"//content/public/common/child_process_sandbox_support_linux.h",
- "//content/public/common/content_descriptors.h",
- "//content/public/common/content_switches.h",
"//content/public/common/main_function_params.h",
- "//content/public/common/mojo_channel_switches.h",
"//content/public/common/sandbox_init.h",
]
@@ -70,9 +69,11 @@ source_set("loader") {
"//components/nacl/common",
"//content/public/common",
"//ppapi/shared_impl",
+ "//services/service_manager/public/cpp",
]
data_deps = [
+ ":nacl_loader_manifest",
"//ppapi/native_client:irt",
"//ppapi/native_client/src/untrusted/pnacl_support_extension",
]
@@ -195,13 +196,6 @@ if (is_nacl_nonsfi) {
output_name = "nacl_helper_nonsfi"
set_sources_assignment_filter([])
sources = [
- # TODO(brettw) can this just depend on //components/nacl/common?
- "../common/nacl_messages.cc",
- "../common/nacl_messages.h",
- "../common/nacl_types.cc",
- "../common/nacl_types.h",
- "../common/nacl_types_param_traits.cc",
- "../common/nacl_types_param_traits.h",
"nacl_helper_linux.cc",
"nacl_helper_linux.h",
"nacl_trusted_listener.cc",
@@ -214,6 +208,7 @@ if (is_nacl_nonsfi) {
deps = [
":nacl_helper_nonsfi_sandbox",
"//base",
+ "//components/nacl/common:minimal",
"//components/nacl/common:switches",
"//components/tracing",
"//content",
@@ -230,6 +225,7 @@ if (is_nacl_nonsfi) {
"//native_client/src/untrusted/nacl",
"//ppapi/proxy",
"//sandbox/linux:sandbox",
+ "//services/service_manager/public/cpp",
]
}
@@ -243,6 +239,7 @@ if (is_nacl_nonsfi) {
]
deps = [
"//base",
+ "//components/nacl/common:minimal",
"//components/nacl/common:switches",
"//content",
"//sandbox/linux:sandbox",
@@ -295,3 +292,8 @@ if (is_nacl_nonsfi) {
]
}
}
+
+service_manifest("nacl_loader_manifest") {
+ name = "nacl_loader"
+ source = "nacl_loader_manifest.json"
+}

Powered by Google App Engine
This is Rietveld 408576698