Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 2501893003: Deprecate case-insensitive matching for |usemap| attribute (Closed)

Created:
4 years, 1 month ago by tkent
Modified:
4 years, 1 month ago
Reviewers:
kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eae+blinkwatch, jam, rwlbuis, sof, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate case-insensitive matching for |usemap| attribute This CL doesn't use Deprecation::countDeprecation() because we'd like to show a deprecation warning message once per a pair of names. This CL uses FrameConsole:: addSingletonMesssage(). Intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8pHdFzN0YQc BUG=659464 Committed: https://crrev.com/b5cd3470950e29229752c7d239ad4a5c9fe18598 Cr-Commit-Position: refs/heads/master@{#433159}

Patch Set 1 #

Messages

Total messages: 26 (21 generated)
tkent
kochi@, would you review this please?
4 years, 1 month ago (2016-11-18 08:24:52 UTC) #20
kochi
lgtm
4 years, 1 month ago (2016-11-18 08:45:18 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501893003/60001
4 years, 1 month ago (2016-11-18 08:50:00 UTC) #23
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 1 month ago (2016-11-18 09:33:09 UTC) #24
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 09:34:50 UTC) #26
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5cd3470950e29229752c7d239ad4a5c9fe18598
Cr-Commit-Position: refs/heads/master@{#433159}

Powered by Google App Engine
This is Rietveld 408576698