Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2501873003: [wasm] Be more lenient on the names section. (Closed)

Created:
4 years, 1 month ago by titzer
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Be more lenient on the names section. R=clemensh@chromium.org,dschuff@chromium.org BUG=v8:5632 LOG=Y Committed: https://crrev.com/6e643f045c9aff643acb36161939a2ee0b236046 Cr-Commit-Position: refs/heads/master@{#41011}

Patch Set 1 #

Patch Set 2 : Fix builders to add empty import names. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M src/wasm/module-decoder.cc View 1 chunk +7 lines, -8 lines 0 comments Download
M src/wasm/wasm-module-builder.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
titzer
4 years, 1 month ago (2016-11-15 19:47:41 UTC) #1
Clemens Hammacher
lgtm
4 years, 1 month ago (2016-11-15 20:05:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2501873003/20001
4 years, 1 month ago (2016-11-15 20:17:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 20:55:40 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:35:04 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6e643f045c9aff643acb36161939a2ee0b236046
Cr-Commit-Position: refs/heads/master@{#41011}

Powered by Google App Engine
This is Rietveld 408576698