third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h - Issue 2501863003: Support for AudioContextOptions latencyHint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h

Issue 2501863003: Support for AudioContextOptions latencyHint. (Closed)

Patch Set: Updates based on reviewer comments. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/DefaultAudioDestinationNode.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/MediaStreamAudioSourceNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp » ('j') | third_party/WebKit/public/platform/WebAudioLatencyHint.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h b/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h

index 30eb3f96250f62172187488c708a8874394ef224..9e53b4cbbb4f1c5c49a0fd3436b124d325096e2e 100644

--- a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h

@@ -59,7 +59,8 @@ class OfflineAudioDestinationHandler final : public AudioDestinationHandler {

void stopRendering() override;

unsigned long maxChannelCount() const override;

- float sampleRate() const override { return m_renderTarget->sampleRate(); }

+ double sampleRate() const override { return m_renderTarget->sampleRate(); }

+ int framesPerBuffer() const override { return 0; }

o1ka 2016/12/02 12:02:13 Is it never expected to be called? DCHECK?

hongchan 2016/12/02 17:40:12 Or NOTREACHED().

Andrew MacPherson 2016/12/05 14:12:53 Done.

size_t renderQuantumFrames() const {

return AudioUtilities::kRenderQuantumFrames;